-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Runfiles tree is not recreated when value of --enable_runfiles changes #9150
Copy link
Copy link
Open
Labels
P3We're not considering working on this, but happy to review a PR. (No assignee)We're not considering working on this, but happy to review a PR. (No assignee)not staleIssues or PRs that are inactive but not considered staleIssues or PRs that are inactive but not considered staleteam-Rules-ServerIssues for serverside rules included with BazelIssues for serverside rules included with Bazeltype: bug
Description
Or more precisely, the old tree persists even when the target is built with --enable_runfiles=false. This causes observable semantic differences when the artifact is sensitive to how the runfiles tree is laid out (or whether it exists at all).
Minimal repro:
# pkg/BUILD
cc_binary(
name = "blah",
srcs = ["blah.cc"],
)// pkg/blah.cc
#include <stdio.h>
int main(int argc, char** argv) {
printf("Hello, world!\n");
return 0;
}$ bazel clean
...
$ bazel run //pkg:blah
...
$ ls bazel-bin/pkg/blah.runfiles
__main__ MANIFEST
$ bazel run //pkg:blah --enable_runfiles=false
...
$ ls bazel-bin/pkg/blah.runfiles
__main__ MANIFEST
$ bazel clean
...
$ bazel run //pkg:blah --enable_runfiles=false
...
$ ls bazel-bin/pkg/blah.runfiles
MANIFESTReactions are currently unavailable
Metadata
Metadata
Assignees
Labels
P3We're not considering working on this, but happy to review a PR. (No assignee)We're not considering working on this, but happy to review a PR. (No assignee)not staleIssues or PRs that are inactive but not considered staleIssues or PRs that are inactive but not considered staleteam-Rules-ServerIssues for serverside rules included with BazelIssues for serverside rules included with Bazeltype: bug