-
Notifications
You must be signed in to change notification settings - Fork 4.4k
Remove --python_path flag #7901
Copy link
Copy link
Open
Labels
P2We'll consider working on this in future. (Assignee optional)We'll consider working on this in future. (Assignee optional)staleIssues or PRs that are stale (no activity for 30 days)Issues or PRs that are stale (no activity for 30 days)team-Rules-PythonNative rules for PythonNative rules for Pythontype: process
Metadata
Metadata
Assignees
Labels
P2We'll consider working on this in future. (Assignee optional)We'll consider working on this in future. (Assignee optional)staleIssues or PRs that are stale (no activity for 30 days)Issues or PRs that are stale (no activity for 30 days)team-Rules-PythonNative rules for PythonNative rules for Pythontype: process
This had to be broken out of #7375 because it turns out
python_pathis used on windows to communicate the location of the Python interpreter even when it's not otherwise available on thePATHat execution time.We can possibly switch this bit of client-server communication to use a hidden flag in place of
--python_path. Alternatively (and probably preferably), we can replace this logic with a repo rule that detects the host platform's Python interpreter, and feed that into the Python toolchain. Another option is to deprecate this bit of niceness and instead require that the interpreter either be available onPATHat execution time or else have its path embedded into an appropriatepy_runtimeof a toolchain definition.