Revert "Enable link time -Os in opt builds (#348)"#372
Merged
Conversation
luispadron
approved these changes
Feb 18, 2025
copybara-service bot
pushed a commit
to openxla/xla
that referenced
this pull request
Mar 10, 2025
To get bazelbuild/apple_support#372 to removes `-Os` from the cc toolchain which isn't supported by old Xcode versions. PiperOrigin-RevId: 735434441
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 10, 2025
To get bazelbuild/apple_support#372 to removes `-Os` from the cc toolchain which isn't supported by old Xcode versions. PiperOrigin-RevId: 735434441
copybara-service bot
pushed a commit
to openxla/xla
that referenced
this pull request
Mar 11, 2025
To get bazelbuild/apple_support#372 to removes `-Os` from the cc toolchain which isn't supported by old Xcode versions. PiperOrigin-RevId: 735434441
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 11, 2025
To get bazelbuild/apple_support#372 to removes `-Os` from the cc toolchain which isn't supported by old Xcode versions. PiperOrigin-RevId: 735434441
copybara-service bot
pushed a commit
to openxla/xla
that referenced
this pull request
Mar 11, 2025
To get bazelbuild/apple_support#372 to removes `-Os` from the cc toolchain which isn't supported by old Xcode versions. PiperOrigin-RevId: 735692983
copybara-service bot
pushed a commit
to tensorflow/tensorflow
that referenced
this pull request
Mar 11, 2025
To get bazelbuild/apple_support#372 to removes `-Os` from the cc toolchain which isn't supported by old Xcode versions. PiperOrigin-RevId: 735692983
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sidestep #371 until
it's fixed in Xcode. Users who still want this vs can pass
--linkopt=-OsThis reverts commit 27df79d.