Enable the archive_param_file feature by default#364
Merged
brentleyjones merged 1 commit intomasterfrom Feb 5, 2025
Merged
Conversation
Matches rules_cc: https://github.com/bazelbuild/rules_cc/blob/6a2520bed08bbe47a8afcf4c43d51c2533d79ed8/cc/private/toolchain/unix_cc_toolchain_config.bzl#L1648. Signed-off-by: Brentley Jones <github@brentleyjones.com>
archive_param_file feature by defaultarchive_param_file feature by default
aaronsky
approved these changes
Feb 5, 2025
luispadron
reviewed
Feb 5, 2025
| features = [ | ||
| # Marker features | ||
| feature(name = "archive_param_file", enabled = True), | ||
| feature(name = "archive_param_file"), |
Contributor
There was a problem hiding this comment.
The rules_cc one is using enabled = True but this removes it, just checking that was expected
Member
There was a problem hiding this comment.
Yea looks like this did the opposite of the description?
Collaborator
Author
There was a problem hiding this comment.
Ohh, dang. Let me revert this. Not sure where the mixup came.
brentleyjones
added a commit
that referenced
this pull request
Feb 5, 2025
This reverts commit ffa42e4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Matches rules_cc: https://github.com/bazelbuild/rules_cc/blob/6a2520bed08bbe47a8afcf4c43d51c2533d79ed8/cc/private/toolchain/unix_cc_toolchain_config.bzl#L1648.