Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bazelbuild/apple_support
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.19.0
Choose a base ref
...
head repository: bazelbuild/apple_support
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.20.0
Choose a head ref
  • 15 commits
  • 44 files changed
  • 2 contributors

Commits on Mar 18, 2025

  1. Update C++ standard default to 17 (#376)

    In accordance with Google's [Foundational C++ Support
    matrix](https://github.com/google/oss-policies-info/blob/main/foundational-cxx-support-matrix.md),
    and given other Google projects have moved to adopt C++17 as a minimum
    or default
    ([protobuf](protocolbuffers/protobuf@fe53593),
    [rules_cc](https://github.com/search?q=repo%3Abazelbuild%2Frules_cc+%22-std%22&type=code)),
    I'd like us to consider bumping this version in apple_support as well.
    
    This constitutes a breaking change. It uses the change made in #219 as a
    reference.
    aaronsky authored Mar 18, 2025
    Configuration menu
    Copy the full SHA
    4e82614 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2025

  1. Configuration menu
    Copy the full SHA
    e9263f0 View commit details
    Browse the repository at this point in the history
  2. Use xcrunwrapper from this repo (#380)

    This way we can delete the one in bazel itself
    keith authored Mar 27, 2025
    Configuration menu
    Copy the full SHA
    f132c5e View commit details
    Browse the repository at this point in the history
  3. Add test for archive file hashes (#384)

    This makes sure we don't break our libtool behavior to hash files if
    there are duplicate basenames
    keith authored Mar 27, 2025
    Configuration menu
    Copy the full SHA
    f19fffc View commit details
    Browse the repository at this point in the history
  4. Remove xcode_version from CI config (#382)

    This does nothing except when 2 versions are available on CI but
    produces a warning in buildkite when the version is invalid
    keith authored Mar 27, 2025
    Configuration menu
    Copy the full SHA
    9652aec View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b33ae04 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    42c5b9b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c4ae462 View commit details
    Browse the repository at this point in the history
  8. Add another case for duplicate object basenames (#387)

    Interestingly today even non-duplicate names are symlinked and hashed.
    I think we should probably change this just for clarities sake but at
    least this encodes today's behavior
    keith authored Mar 27, 2025
    Configuration menu
    Copy the full SHA
    9e2e56d View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2025

  1. Configuration menu
    Copy the full SHA
    9d23ab4 View commit details
    Browse the repository at this point in the history
  2. Fix generate_linkmap for cc_binary (#389)

    There are 2 separate codepaths for linkmaps, `--objc_generate_linkmap`
    enables the `linkmap_exec_path` variable, and just passing
    `--features=generate_linkmap` enables linkmap outputs, without any other
    variables.
    keith authored Mar 28, 2025
    Configuration menu
    Copy the full SHA
    88c2edc View commit details
    Browse the repository at this point in the history
  3. Replace libtool shell template with C++ (#388)

    This combines libtool.sh.tpl, libtool_check_unique.cc, xcrunwrapper.sh,
    and make_hashed_objlist.py into a single C++ driver.
    
    This sidesteps issues with our toolchain tools having to discover
    each other, and reduces some duplication in this setup.
    keith authored Mar 28, 2025
    Configuration menu
    Copy the full SHA
    525cdda View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    73a97a6 View commit details
    Browse the repository at this point in the history
  5. Add 7.x CI job (#392)

    keith authored Mar 28, 2025
    Configuration menu
    Copy the full SHA
    abf8c97 View commit details
    Browse the repository at this point in the history
  6. Move toolchain tool setup out of repo rule (#393)

    Now that we're building the tools used in the toolchain as normal rules,
    there's really no need for them to be part of the toolchain setup. This
    is more understandable in general since it removes a layer of
    indirection.
    keith authored Mar 28, 2025
    Configuration menu
    Copy the full SHA
    3483cfe View commit details
    Browse the repository at this point in the history
Loading