Make gazelle_python_manifest output deterministic#813
Merged
f0rmiga merged 3 commits intobazel-contrib:mainfrom Aug 30, 2022
abhishekshivanna:issue_812
Merged
Make gazelle_python_manifest output deterministic#813f0rmiga merged 3 commits intobazel-contrib:mainfrom abhishekshivanna:issue_812
f0rmiga merged 3 commits intobazel-contrib:mainfrom
abhishekshivanna:issue_812
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
f0rmiga
suggested changes
Aug 29, 2022
Member
|
@abhishekshivanna thanks for the contribution! |
f0rmiga
approved these changes
Aug 30, 2022
Member
|
@abhishekshivanna thanks for addressing my comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When invoking the update rule on
gazelle_python_manifestthe output generated to
gazelle_python.yamlmapping fileis not deterministic.
This non-determinism causes the test rule for
gazelle_python_manifestto always fail.
This patch fixes the bug by sorting the keys before writing it to the
mapping file, making the output deterministic
Test Plan: Existing unit tests to verify the output
Fixes #812
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #812
What is the new behavior?
See commit summary
Does this PR introduce a breaking change?
Other information