py_library generated from wheel shouldn't include tests/ folder#528
Merged
alexeagle merged 1 commit intobazel-contrib:mainfrom Sep 12, 2021
Merged
py_library generated from wheel shouldn't include tests/ folder#528alexeagle merged 1 commit intobazel-contrib:mainfrom
alexeagle merged 1 commit intobazel-contrib:mainfrom
Conversation
thundergolfer
approved these changes
Sep 12, 2021
thundergolfer
left a comment
There was a problem hiding this comment.
This is only a heuristic, but from checking ~50 of the top ~300 wheels
at https://pythonwheels.com/ tests/ seems by far the most common. Others do exist though, and look safe to also exclude. I saw:
test/:urllib3testing/:cffi{name}/tests/:certifi,colorama,pandas,google-auth-core,jsonschema
Contributor
Author
|
Thanks for doing that research. I'd worry about excluding |
This is a python convention that wheels are shipped to pypi including their tests. These shouldn't be used in user code. We have observed these files expose modules which collide with first-party targets.
792e118 to
2a9819c
Compare
alexeagle
added a commit
to alexeagle/rules_python
that referenced
this pull request
Sep 23, 2021
…ers (bazel-contrib#528)" This reverts commit 7609526. Fixes bazel-contrib#538
hrfuller
added a commit
that referenced
this pull request
Sep 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a python convention that wheels are shipped to pypi including their tests.
These shouldn't be used in user code.
We have observed these files expose modules which collide with first-party targets.
PR Checklist
Please check if your PR fulfills the following requirements:
.parfiles. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information