Add all_whl_requirements to match all_requirements#377
Merged
thundergolfer merged 3 commits intobazel-contrib:masterfrom Jan 5, 2021
Merged
Add all_whl_requirements to match all_requirements#377thundergolfer merged 3 commits intobazel-contrib:masterfrom
all_whl_requirements to match all_requirements#377thundergolfer merged 3 commits intobazel-contrib:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Contributor
Author
|
@googlebot I signed it! |
77e42a6 to
2bbfedb
Compare
hrfuller
approved these changes
Nov 25, 2020
Contributor
There was a problem hiding this comment.
@person142 Thanks for the contribution.
@thundergolfer This LGTM.
| name_key = name.replace("-", "_").replace(".", "_").lower() | ||
| return "{repo}//pypi__" + name_key | ||
|
|
||
| all_whl_requirements = [{whl_requirement_labels}] |
Contributor
There was a problem hiding this comment.
Nit: Put this underneath all_requirements so the macros are separated visually from the static definitions.
2bbfedb to
b6886f2
Compare
hrfuller
approved these changes
Dec 25, 2020
thundergolfer
approved these changes
Jan 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
.parfiles. See CONTRIBUTING.md for infoPR Type
What kind of change does this PR introduce?
What is the current behavior?
There isn't an equivalent to
all_requirementsforwhl_requirement.What is the new behavior?
A list
all_whl_requirementsis added torequirements.bzlwhich contains all of the wheel targets.Does this PR introduce a breaking change?
Other information
The
all_whl_requirementslist is handy if you want to write a target that takes all of the wheels built byrules_pythonand upload them to a private wheelhouse say.