fix: configure coverage helpers for test exec group#2857
fix: configure coverage helpers for test exec group#2857rickeylev merged 1 commit intobazel-contrib:mainfrom
Conversation
7f1556c to
d8f9953
Compare
They are run on the test action's execution platform, which is resolved for the `test` exec group, not the default one. Since this adds a reference to the `test` exec group, which is only defined for test rules, `py_executable` attrs must not merge in coverage attributes if the rule to be created is not a test rule.
d8f9953 to
a1fe2ff
Compare
|
LGHM, but I lack the context behind the reason why we are fixing it. I am +1 for merging but love if you could point me to extra docs. Does this fix a particular issue or does this just make things more tidy? |
|
The docs don't exist yet, but I'm adding them in bazelbuild/bazel#25996. We can link to that once it lands (and wait for it to get merged if you prefer that). In a cross-platform build with custom exec constraints on either the |
|
Would this fix #2850 ? The error in that report seems related to the test toolchain |
|
It wouldn't, but I will send a fix for that other issue. |
They are run on the test action's execution platform, which is resolved for the
testexec group, not the default one.