fix: requires_file preserves extras that package depends on#2807
Merged
aignas merged 3 commits intobazel-contrib:mainfrom May 2, 2025
Merged
Conversation
skongum02
commented
Apr 22, 2025
| py_wheel( | ||
| name = "requires_dist_depends_on_extras", | ||
| distribution = "requires_dist_depends_on_extras", | ||
| requires = [ |
Contributor
Author
There was a problem hiding this comment.
This currently passes without any code changes, but just adding this for completeness
Contributor
Author
|
Hello @rickeylev @aignas any chance you all can take a look at this PR? |
aignas
reviewed
Apr 29, 2025
Collaborator
aignas
left a comment
There was a problem hiding this comment.
The change LGTM. Could you please add a line to the Fixed section in CHANGELOG?
4403859 to
26daecb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When requirements are passed in through
requires_filethe extras are not preserved.eg if the contents of requires file is
example[extras]==1.1.1, bazel will currently write to the METADATA fileRequires-Dist: example==1.1.1. This PR attempts to fix that by adding that back if there are any extras.The expected output should be
Requires-Dist: example[extras]==1.1.1