tests: use $(rootpaths) to get executable files paths for Bazel 8 compatibility#2395
Merged
rickeylev merged 4 commits intobazel-contrib:mainfrom Nov 12, 2024
Merged
Conversation
aignas
approved these changes
Nov 12, 2024
Collaborator
aignas
left a comment
There was a problem hiding this comment.
The MODULE.bazel.lock file change looks weird - I don't see why it would have to change - is it the .bazelignore or are we missing some CI checks...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Bazel 8, the singular
$(rootpath)expansions require that the target expands to asingle file. The py rules have an unfortunate legacy behavior where their default outputs
are the executable and the main py file, thus causing an error.
To fix, use the plural
$(rootpaths), then post-process the space-separated string to getjust the executable portion of it.
Along the way...
This avoids an infinite symlink expansions error and performance issues when those
symlinks exist.
Work towards #2378