chore: remove references to @rules_cc//cc:defs.bzl#2293
chore: remove references to @rules_cc//cc:defs.bzl#2293rickeylev merged 18 commits intobazel-contrib:mainfrom
Conversation
|
I don't see any reason the RBE jobs have to build with Bazel 6.4.0 and ubuntu1604, please upgrade to Bazel 7.3.2 and ubuntu2204 |
|
We still support Bazel 6, so we should have an RBE for that. Do you mean for the Bazel 7 RBE job? It looks like its using 7.1 (which is a bit surprising; I thought our CI was setup to use 7.x, i.e. latest 7) |
|
I'm not sure which one is the Bazel 7 RBE job, but the for those RBE jobs, you should upgrade to If Bazel 6 is still supported, then we need to fix rules_cc, sent bazelbuild/rules_cc#253 |
|
FYI, once bazel 8 is out, we will start removing support for bazel 6, but if we can maintain compatibility in an easy way that wouldn't hurt. As for bazel version, we are defining it in |
This is per bazel-contrib#2293 (comment) From what I can tell ubuntu1604 is very old and not well supported.
CI still show some failures, though. Some look related to compiling protobuf? |
This is per #2293 (comment) From what I can tell ubuntu1604 is very old and not well supported.
|
Once #2379 is merged, I think this PR will be able to finally proceed. That PR drops Bazel 6 support and updates to rules_cc 0.0.14, which I think are prereqs for moving past rules_cc 0.0.9 |
|
Updated to head, CI looking green. Looks like 2379 helped with this quite a bit. |
Referring to @rules_cc//cc:defs.bzl, refers to @protobuf//bazel:cc_proto_library.bzl, which fetches protobuf repository.
Referring directly to what's needed limits the fetches just to rules_cc.
Fix reference to bzl libs in rules_cc that are needed for docs generation.
This requires rules_cc 0.0.13 or higher.
Work towards #2387, #2378