fix(toolchain): symlink all toolchain files for the host toolchain#1745
Merged
fix(toolchain): symlink all toolchain files for the host toolchain#1745
Conversation
Use the same binary path that the regular toolchain is using in an attempt to see if the behaviour is any different. Attempt to fix #1723
f0rmiga
approved these changes
Feb 6, 2024
This requires admin privileges and it seems `bazel` and a few other project may have relied on us just working without symlink support. This may break more things, so let's see what the CI says.
Collaborator
Author
|
I don't think this is fixing anything yet, so I have removed it from the queue for now, I am working on an alternative fix. Will mark as a draft. |
meteorcloudy
reviewed
Feb 6, 2024
meteorcloudy
reviewed
Feb 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we would only symlink the interpreter binary itself
when creating the hermetic host toolchain used in setting up the
whl_libraryrepositories. This works on UNIX platforms and Windowsif they have the following in their
.bazelrc:In our CI we had the same lines but the users did not need to add them
until the
0.29.0forced them to have them because we actually startedusing symlinks on Windows. If the symlinks are not enabled on the host
platform
bazeltries to be helpful and copies the files over insteadof making the links. We are leveraging this to just symlink all of the
contents of the python interpreter repository for the host platform to
the
_hosttoolchain repository.Fixes #1723