chore: enable bzlmod by default (for Bazel 6)#1632
Merged
rickeylev merged 22 commits intobazel-contrib:mainfrom Dec 21, 2023
Merged
chore: enable bzlmod by default (for Bazel 6)#1632rickeylev merged 22 commits intobazel-contrib:mainfrom
rickeylev merged 22 commits intobazel-contrib:mainfrom
Conversation
This enables bzlmod by default so that, by default, builds are using it for both Bazel 6 and Bazel 7.
aignas
approved these changes
Dec 20, 2023
…on into enable.bzlmod.default
* Also moves non-example integration tests under tests/integration
065d3a7 to
8b66bb5
Compare
the min_workspace will use the same bazel version as workspace, so no need to run both.
…oken and hasnt run in a long time
… name in presubmit config
…on into enable.bzlmod.default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables bzlmod by default so that, by default, builds are using it for both Bazel 6
and Bazel 7.
This exposed some gaps in our test coverage, so some new jobs are created to cover
minimum bzlmod and workspace versions. Basically, our CI config used mostly
workspace builds, while Bazel's downstream testing used bzlmod builds. Changing
our config to default to bzlmod means we lost most workspace build coverage.
Unfortunately, adding these new jobs goes over the CI job limit, so I consolidated
tests a bit:
about 6 jobs
just one of the two. This saves about 4 jobs. Many jobs still test both, so coverage
should still be sufficient.
Also some various cleanups:
bazel_integration_test. It hasn't been running in a long time and is broken.