Skip to content

fix(examples): bump gazelle in examples/build_file_generation#1421

Merged
aignas merged 5 commits intobazel-contrib:mainfrom
OliverFM:oliver/fix-buildfile-generation
Oct 13, 2023
Merged

fix(examples): bump gazelle in examples/build_file_generation#1421
aignas merged 5 commits intobazel-contrib:mainfrom
OliverFM:oliver/fix-buildfile-generation

Conversation

@OliverFM
Copy link
Copy Markdown
Contributor

@OliverFM OliverFM commented Sep 20, 2023 •
edited by aignas
Loading

This PR fixes some broken examples in examples/build_file_generation – because gazelle needed to be updated.

After this PR, bazel run //:requirements.update && bazel run //:gazelle_python_manifest.update && bazel run //:gazelle no runs. Moreover if you delete the autogenerated sections of the BUILD.bazel file, it will regenerate them.

Fixes #1372

@google-cla
Copy link
Copy Markdown

google-cla bot commented Sep 20, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@OliverFM OliverFM marked this pull request as ready for review September 20, 2023 10:05
@OliverFM OliverFM requested a review from f0rmiga as a code owner September 20, 2023 10:05
@aignas
Copy link
Copy Markdown
Collaborator

aignas commented Sep 21, 2023

Thanks for the PR @OliverFM, could you please sign the CLA and fix buildifier errors?

@OliverFM
Copy link
Copy Markdown
Contributor Author

OliverFM commented Sep 26, 2023

Thanks for the PR @OliverFM, could you please sign the CLA and fix buildifier errors?

Will do! I've been away for the last week, but can fix this sometime in the next few days when I am back with my laptop :)

@OliverFM
Copy link
Copy Markdown
Contributor Author

OliverFM commented Oct 1, 2023

@aignas I think that this is all sorted – though the CLA change has not showed up yet

@aignas
Copy link
Copy Markdown
Collaborator

aignas commented Oct 1, 2023

@OliverFM It seems that ❌ https://github.com/bazelbuild/rules_python/commit/206537498aae89053230087ba987618cc5fb14f9 Author: <ol***r​@wayve.ai> is the offender with the CLA. Could you please rewrite the git commit history with git commit --amend --author please? Squashing everything to a single commit and then doing it should fix the issue.

@OliverFM OliverFM force-pushed the oliver/fix-buildfile-generation branch from 7e11dc8 to 5079e51 Compare October 2, 2023 09:22
f0rmiga
f0rmiga previously requested changes Oct 4, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@f0rmiga f0rmiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

examples/build_file_generation/WORKSPACE Outdated
)

# Download the bazel_gazelle ruleset.
GAZELLE_VERSION = "0.33.0"
Copy link
Copy Markdown
Member

@f0rmiga f0rmiga Oct 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually a bad refactor, especially to put into examples. Many people use renovate to bump dependencies and it won't understand this. Could you bump the dependency without making this refactor, please?

Copy link
Copy Markdown
Contributor Author

@OliverFM OliverFM Oct 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, I hadn't realised that was why it was setup that way. I will make that change :)

Copy link
Copy Markdown
Contributor Author

@OliverFM OliverFM Oct 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done -- will rerequest review when CI passes

@OliverFM OliverFM requested a review from f0rmiga October 11, 2023 17:13
@aignas aignas changed the title Fix examples/build_file_generation by bumping rules fix(examples): bump gazelle in examples/build_file_generation Oct 13, 2023
@aignas aignas dismissed f0rmiga’s stale review October 13, 2023 04:49

This is a trivial change now and merging it in order to fix the examples.

@aignas aignas added this pull request to the merge queue Oct 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 13, 2023
@aignas aignas added this pull request to the merge queue Oct 13, 2023
Merged via the queue into bazel-contrib:main with commit c2a2f79 Oct 13, 2023
linzhp pushed a commit to linzhp/rules_python that referenced this pull request Oct 15, 2023
@OliverFM @linzhp
fix(examples): bump gazelle in examples/build_file_generation (bazel-…
cc55561 
…contrib#1421)

This PR fixes some broken examples in `examples/build_file_generation` –
because `gazelle` needed to be updated.

After this PR, `bazel run //:requirements.update && bazel run
//:gazelle_python_manifest.update && bazel run //:gazelle` no runs.
Moreover if you delete the autogenerated sections of the `BUILD.bazel`
file, it will regenerate them.

Fixes bazel-contrib#1372
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aignas aignas aignas approved these changes

@f0rmiga f0rmiga Awaiting requested review from f0rmiga

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Gazelle example in examples/build_file_generation is broken.

3 participants

@OliverFM @aignas @f0rmiga