feat: add a tool to update internal dependencies#1321
Merged
rickeylev merged 13 commits intobazel-contrib:mainfrom Aug 3, 2023
Merged
feat: add a tool to update internal dependencies#1321rickeylev merged 13 commits intobazel-contrib:mainfrom
rickeylev merged 13 commits intobazel-contrib:mainfrom
Conversation
3b2b838 to
9d2dd29
Compare
chrislovecnm
previously requested changes
Jul 17, 2023
Contributor
chrislovecnm
left a comment
There was a problem hiding this comment.
Thank you! Just nit picks
Collaborator
Author
|
@chrislovecnm, thanks for the initial comments. I have decided to rewrite the |
Contributor
|
@aignas I'm going to let @rickeylev or some other Python guru do a code review on this. My only comment is that you don't have public function docs. |
rickeylev
requested changes
Aug 1, 2023
Before this change the updates to the dependencies would happen very seldomly, with this script, I propose we do it before each minor version release. Adding a shell script and adding a reminder to the release process may help with that.
…ng pip_install deps
Make tools work via bazel
aignas
commented
Aug 2, 2023
Collaborator
Author
aignas
left a comment
There was a problem hiding this comment.
Added extra tests.
97b0e1b to
4ef2d0d
Compare
4ef2d0d to
ccd5ce0
Compare
rickeylev
approved these changes
Aug 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this change the updates to the dependencies would happen very
seldomly, with this script, I propose we do it before each minor version
release. Adding a shell script and adding a reminder to the release
process may help with that.