Skip to content

feat: Create all_data_requirements alias#1292

Merged
chrislovecnm merged 5 commits intobazel-contrib:mainfrom
kevinpark1217:main
Jul 11, 2023
Merged

feat: Create all_data_requirements alias#1292
chrislovecnm merged 5 commits intobazel-contrib:mainfrom
kevinpark1217:main

Conversation

@kevinpark1217
Copy link
Copy Markdown
Contributor

@kevinpark1217 kevinpark1217 commented Jul 3, 2023 •
edited
Loading

Minor change.

I am creating a Python virtualenv with Bazel, and having all_data_requirements for data dependencies just like all_requirements would be very helpful.

@kevinpark1217 kevinpark1217 requested a review from hrfuller as a code owner July 3, 2023 23:22
@google-cla
Copy link
Copy Markdown

google-cla bot commented Jul 3, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kevinpark1217 kevinpark1217 changed the title Create all_data_requirements alias feat: Create all_data_requirements alias Jul 3, 2023
@kevinpark1217 kevinpark1217 requested a review from rickeylev as a code owner July 3, 2023 23:42
@kevinpark1217
Copy link
Copy Markdown
Contributor Author

kevinpark1217 commented Jul 5, 2023

Hello @hrfuller @rickeylev, can I get a review?

@chrislovecnm
Copy link
Copy Markdown
Contributor

chrislovecnm commented Jul 10, 2023 •
edited
Loading

How can we test this? Can we add something to one of our examples?

@kevinpark1217
Copy link
Copy Markdown
Contributor Author

kevinpark1217 commented Jul 10, 2023 •
edited
Loading

How can we test this? Can we add something to one of our examples?

Hi @chrislovecnm, I added a build_test() under examples/bzlmod. Also, examples/pip_parse_vendored/requirements.bzl shows the generated output.

chrislovecnm
chrislovecnm approved these changes Jul 10, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@chrislovecnm chrislovecnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - if you could add some documentation in the examples, that would rock!

@chrislovecnm chrislovecnm added this pull request to the merge queue Jul 10, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 10, 2023
@chrislovecnm chrislovecnm added this pull request to the merge queue Jul 11, 2023
Merged via the queue into bazel-contrib:main with commit 3608207 Jul 11, 2023
@aignas aignas mentioned this pull request Jul 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hrfuller hrfuller Awaiting requested review from hrfuller

@rickeylev rickeylev Awaiting requested review from rickeylev rickeylev is a code owner

1 more reviewer

@chrislovecnm chrislovecnm chrislovecnm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kevinpark1217 @chrislovecnm