fix: plugin_output in py_proto_library rule#1280
Merged
chrislovecnm merged 2 commits intobazel-contrib:mainfrom Jun 20, 2023
Merged
fix: plugin_output in py_proto_library rule#1280chrislovecnm merged 2 commits intobazel-contrib:mainfrom
chrislovecnm merged 2 commits intobazel-contrib:mainfrom
Conversation
rickeylev
approved these changes
Jun 20, 2023
Collaborator
rickeylev
left a comment
There was a problem hiding this comment.
Is there an issue somewhere describing the bug in more detail? Or did you just come across this accidentally?
Otherwise lgtm
Contributor
Author
Accidentally. We had the same problem internally, reported on b/277335175. And I spent a month fixing _virtual_imports and otherwise generally cleaning up/optimising proto_library implementation. |
eed3si9n
pushed a commit
to eed3si9n/rules_python
that referenced
this pull request
Aug 24, 2023
plugin_output was wrong in case multiple repositories are involved and/or _virtual_imports. The code is taken from `cc_proto_library` and has been verified in practice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plugin_output was wrong in case multiple repositories are involved and/or _virtual_imports.
The code is taken from
cc_proto_libraryand has been verified in practice.