fix(concatjs): resolve error with TypeScript 4.7#3420
Merged
alexeagle merged 1 commit intobazel-contrib:stablefrom Apr 22, 2022
Merged
fix(concatjs): resolve error with TypeScript 4.7#3420alexeagle merged 1 commit intobazel-contrib:stablefrom
alexeagle merged 1 commit intobazel-contrib:stablefrom
Conversation
In TypeScript 4.7 the first argument of `resolveTypeReferenceDirectives` can be a `FileReference[]`, in addition to a `string[]`. These changes resolve a runtime error that was happening as result.
Contributor
Author
|
I'm not sure why CircleCI timed out here, but I don't have permissions to restart it. |
alexeagle
approved these changes
Apr 22, 2022
Collaborator
alexeagle
left a comment
There was a problem hiding this comment.
Thanks!
Feels like we should somehow give the concatjs package back to Angular/Google teams since it's nearly deprecated externally...
Contributor
|
@alexeagle Yes. This year, I have plans to move the ts library portion at least into the Angular dev-infra repo, w/ some |
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
Apr 29, 2022
Adds support for TypeScript 4.7. Changes include: * Bumping the TS version as well as some Bazel dependencies to include bazel-contrib/rules_nodejs#3420. * Adding a backwards-compatibility layer for calls to `updateTypeParameterDeclaration`. * Making `LView` generic in order to make it easier to type the context based on the usage. Currently the context can be 4 different types which coupled with stricter type checking would required a lot of extra casting all over `core`. * Fixing a bunch of miscellaneous type errors. * Removing assertions of `ReferenceEntry.isDefinition` in a few of the language service tests. The field isn't returned by TS anymore and we weren't using it for anything. * Resolving in error in the language service that was caused by TS attempting to parse HTML files when we try to open them. Previous TS was silently setting them as `ScriptKind.Unknown` and ignoring the errors, but now it throws. I've worked around it by setting them as `ScriptKind.JSX`.
dylhunn
pushed a commit
to angular/angular
that referenced
this pull request
Apr 29, 2022
Adds support for TypeScript 4.7. Changes include: * Bumping the TS version as well as some Bazel dependencies to include bazel-contrib/rules_nodejs#3420. * Adding a backwards-compatibility layer for calls to `updateTypeParameterDeclaration`. * Making `LView` generic in order to make it easier to type the context based on the usage. Currently the context can be 4 different types which coupled with stricter type checking would required a lot of extra casting all over `core`. * Fixing a bunch of miscellaneous type errors. * Removing assertions of `ReferenceEntry.isDefinition` in a few of the language service tests. The field isn't returned by TS anymore and we weren't using it for anything. * Resolving in error in the language service that was caused by TS attempting to parse HTML files when we try to open them. Previous TS was silently setting them as `ScriptKind.Unknown` and ignoring the errors, but now it throws. I've worked around it by setting them as `ScriptKind.JSX`. PR Close #45749
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In TypeScript 4.7 the first argument of
resolveTypeReferenceDirectivescan be aFileReference[], in addition to astring[]. These changes resolve a runtime error that was happening as result.