fix(jasmine): replace deprecated Jasmine APIs that have been removed in version 4#3283
Merged
alexeagle merged 1 commit intobazel-contrib:stablefrom Jan 26, 2022
Merged
Conversation
6fbc083 to
eef5e9e
Compare
eef5e9e to
66e7c8a
Compare
Contributor
Author
|
Looks like with this change we can only support Jasmine 3.10+ https://jasmine.github.io/api/npm/3.10/Jasmine. So, I guess we need to support the older and new API since technically speaking changing the peer deps can be considered as a breaking change. |
66e7c8a to
dc978e3
Compare
10 tasks
dc978e3 to
48e7c5a
Compare
2c63fa8 to
e263803
Compare
alexeagle
approved these changes
Jan 26, 2022
Collaborator
alexeagle
left a comment
There was a problem hiding this comment.
Thanks Alan! Looks great as always, just one comment nit
…in version 4 With this change we replace APIs that have been deprecated in version 4 and removed in version 4 ``` Jasmine#onComplete is deprecated. Instead of calling onComplete, set the Jasmine instance's exitOnCompletion property to false and use the promise returned from the execute method. ``` Also this addresses the breaking change in version 4 https://github.com/jasmine/jasmine/blob/main/release_notes/4.0.0.md#changes-that-affect-custom-reporters in a backward compatible manner. Closes bazel-contrib#3289
e263803 to
80f6d55
Compare
Contributor
Author
|
@alexeagle todos added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change we replace APIs that have been deprecated in version 4 and removed in version 4
Also this addresses the breaking change in version 4 https://github.com/jasmine/jasmine/blob/main/release_notes/4.0.0.md#changes-that-affect-custom-reporters in a backward compatible manner.