Skip to content

Error using Jasmine 4.0 and jasmine_node_test #3289

@jstuder-gh

Description

@jstuder-gh

🐞 bug report

Affected Rule

jasmine_node_test

Is this a regression?

No

Description

When using Jasmine 4.0 there is an error when executing jasmine_runner.js. The runner script is using the onComplete method which has been removed in 4.0. In addition the jasmine.Spec and jasmine.Suite identifiers used when gathering Specs for sharding are no longer accessible.

🔬 Minimal Reproduction

Upgrade jasmine and jasmine-core packages to 4.0.0. Then run jasmine tests.

bazelisk test //packages/jasmine/...

🔥 Exception or Error


INFO: From Testing //packages/jasmine/test:generated_require_spec_test:
==================== Test output for //packages/jasmine/test:generated_require_spec_test:
[jasmine_runner.js] An error has been reported: TypeError: jrunner.onComplete is not a function
    at main (packages/jasmine/jasmine_runner.js:119:11)
    at packages/jasmine/jasmine_runner.js:182:32
    at Object. (packages/jasmine/jasmine_runner.js:187:5)
    at Module._compile (node:internal/modules/cjs/loader:1095:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1124:10)
    at Module.load (node:internal/modules/cjs/loader:975:32)
    at Function.Module._load (node:internal/modules/cjs/loader:816:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:79:12)
    at node:internal/main/run_main_module:17:47

🌍 Your Environment

Operating System:

  
  Linux x86_64
  

Output of bazel version:

  
  5.0.0
  

Rules_nodejs version:

  
  5.0.1
  

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions