Allow package exclusions and inclusions in javadocs#1293
Merged
shs96c merged 13 commits intobazel-contrib:masterfrom Jun 26, 2025
Merged
Allow package exclusions and inclusions in javadocs#1293shs96c merged 13 commits intobazel-contrib:masterfrom
shs96c merged 13 commits intobazel-contrib:masterfrom
Conversation
vinnybod
commented
Dec 5, 2024
| updated_deploy_env = deploy_env + [KOTLIN_STDLIB] | ||
| else: | ||
| updated_deploy_env = deploy_env | ||
| updated_excluded_workspaces = {name: None for name in excluded_workspaces} |
Contributor
Author
There was a problem hiding this comment.
deploy_env gets added back into the docs so we were generating docs for kotlin stdlib which seems wrong. Changed to excluded_workspace to keep it out of the docs, which seems like what was actually intended.
This is also how we handle scala_export in confluent's fork of rules_jvm_external.
Contributor
Author
|
Hm, only windows is failing. not sure why |
shs96c
approved these changes
Jun 26, 2025
Collaborator
shs96c
left a comment
There was a problem hiding this comment.
I'm slightly worried by the sheer number of parameters appearing on java_export, but I can see why this is needed. Thank you for the PR!
shs96c
added a commit
to jin/rules_jvm_external
that referenced
this pull request
Jul 4, 2025
* master: (39 commits) Fix resolution of Android/AAR artifacts with Gradle resolver (bazel-contrib#1395) fail_if_repin_required is now True by default and minor improvement to failure message (bazel-contrib#1397) Housekeeping before we release 6.8 (bazel-contrib#1384) Add dll, dylib and so types to maven package mappings (bazel-contrib#1392) [bzlmod] Allow suppressing warning about multiple contributing modules. (bazel-contrib#1393) Use the artifact default values when adding them to a struct and add tests for coursier artifacts that have empty versions provided by BOMs and don't inlcude them in outdated (bazel-contrib#1390) Allow package exclusions and inclusions in javadocs (bazel-contrib#1293) Document well-known issues with `bzlmod` (bazel-contrib#1388) Begin documenting the gradle resolver (bazel-contrib#1389) Run gradle regression tests in CI (bazel-contrib#1385) Modify maven_export to allow exporting zip archives (bazel-contrib#1368) Allow root module's override tags to take precedence over the overridees from transitive deps. (bazel-contrib#1381) Ensure root module artifacts and boms take precedence with warnings (bazel-contrib#1373) Update maven-metadata.xml when publishing locally (bazel-contrib#1369) Add support for gradle resolver (bazel-contrib#1357) Prepare for 6.8 release (bazel-contrib#1380) Remove the Windows `kt_jvm_export` example (bazel-contrib#1383) Avoid spurious warnings about poorly formatted artifact coordinates (bazel-contrib#1374) Flip `fail_if_repin_required` to `True` by default (bazel-contrib#1371) Allow the same coordinate to be overridden in different repos (bazel-contrib#1378) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are times where developers want to exclude specific packages from being generated in the javadocs such as internal code. This is commonly offered as a feature of javadoc generation in both maven and gradle.
An exact package can be provided to remove the first level of files, or a
.*to remove all subpackages under it.