Skip to content

Make .bzl files compatible with future versions of Bazel#726

Merged
ianthehat merged 1 commit intobazel-contrib:masterfrom
vladmos:lists_plus_equals
Aug 21, 2017
Merged

Make .bzl files compatible with future versions of Bazel#726
ianthehat merged 1 commit intobazel-contrib:masterfrom
vladmos:lists_plus_equals

Conversation

@vladmos
Copy link
Copy Markdown
Contributor

@vladmos vladmos commented Aug 16, 2017

In Bazel 0.6 the += operator on lists will have mutating semantics instead of copying. Some .bzl files have to be updated to be compatible with both semantics.

Protobuf is updated for the same reason.

@vladmos
Copy link
Copy Markdown
Contributor Author

vladmos commented Aug 16, 2017

Please release a new version with this update so that it can be imported from other projects that use rules_go, such as rules_webtesting. Thanks.

@ianthehat
Copy link
Copy Markdown
Contributor

There are some major changes pending, that may be affected. How do you find which cases need fixing and which don't?
We can't easily tag a new version right now, there are lots of breaking changes we don't want to inflict on people in a trickle, so we are not going to tag a new version until after we can get toolchain support submitted and we are sure it is stable, which is waiting for Bazel 0.5.4 to ship. If it's really important then we need to branch from the current release tag and cherry pick.

@vladmos
Copy link
Copy Markdown
Contributor Author

vladmos commented Aug 16, 2017

I need to use these changes before a release candidate for Bazel 0.6 is created, which will happen shortly after Bazel 0.5.4 is out. If it's not possible to release rules_go immediately after Bazel 0.5.4 is out it would be nice to have a cherry-pick release, in that case f083e0f should be included there too. Both changes are compatible with old versions (must work with 0.5 at least) so it shouldn't be a problem. I don't think the proto library has incompatible breaking changes.

@jayconrod jayconrod mentioned this pull request Aug 16, 2017
@ianthehat ianthehat merged commit 5b4257c into bazel-contrib:master Aug 21, 2017
yushan26 pushed a commit to yushan26/rules_go that referenced this pull request Jun 16, 2025
* Remove legacy pip_import

* Remove legacy pip_import

* Generate docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants