Add riscv64 into BAZEL_GOARCH_CONSTRAINTS#4507
Merged
fmeum merged 1 commit intobazel-contrib:masterfrom Nov 7, 2025
ffgan:master
Merged
Add riscv64 into BAZEL_GOARCH_CONSTRAINTS#4507fmeum merged 1 commit intobazel-contrib:masterfrom ffgan:master
riscv64 into BAZEL_GOARCH_CONSTRAINTS#4507fmeum merged 1 commit intobazel-contrib:masterfrom
ffgan:master
Conversation
Co-authored by: nijincheng@iscas.ac.cn;
fmeum
approved these changes
Nov 7, 2025
This was referenced Nov 12, 2025
ffgan
added a commit
to ffgan/rules_go
that referenced
this pull request
Jan 8, 2026
<!-- Thanks for sending a PR! Before submitting: 1. If this is your first PR, please read CONTRIBUTING.md and sign the CLA first. We cannot review code without a signed CLA. 2. Please file an issue *first*. All features and most bug fixes should have an associated issue with a design discussed and decided upon. Small bug fixes and documentation improvements don't need issues. 3. New features and bug fixes must have tests. Documentation may need to be updated. If you're unsure what to update, send the PR, and we'll discuss in review. 4. Note that PRs updating dependencies and new Go versions are not accepted. Please file an issue instead. --> **What type of PR is this?** Bug fix **What does this PR do? Why is it needed?** Fix some Bazel matching issues on riscv64 **Which issues(s) does this PR fix?** Fixes bazel-contrib#4053 **Other notes for review** The riscv64 architecture has been widely developed and adopted recently, and optimizing support for riscv64 is very meaningful as it can provide better riscv64 support for downstream users. For example, when I was using `bazeldnf`, due to some limitations in the current repository, I couldn't use `bazeldnf` directly. The specific reason is this: https://github.com/rmohr/bazeldnf/blob/main/bazeldnf/platforms.bzl. This depends on the current repository's `BAZEL_GOARCH_CONSTRAINTS`, which currently lacks riscv64 support, so the riscv64 version of bazeldnf cannot be used directly. If this PR is merged and released, downstream users will be able to get good riscv64 support. A PR quite similar to this one is bazel-contrib#3336. I think the situation with riscv64 is quite similar to that case. The Go upstream also provides good support for riscv64. **Other Info** Co-authored by: nijincheng@iscas.ac.cn;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
Fix some Bazel matching issues on riscv64
Which issues(s) does this PR fix?
Fixes #4053
Other notes for review
The riscv64 architecture has been widely developed and adopted recently, and optimizing support for riscv64 is very meaningful as it can provide better riscv64 support for downstream users.
For example, when I was using
bazeldnf, due to some limitations in the current repository, I couldn't usebazeldnfdirectly. The specific reason is this: https://github.com/rmohr/bazeldnf/blob/main/bazeldnf/platforms.bzl. This depends on the current repository'sBAZEL_GOARCH_CONSTRAINTS, which currently lacks riscv64 support, so the riscv64 version of bazeldnf cannot be used directly. If this PR is merged and released, downstream users will be able to get good riscv64 support.A PR quite similar to this one is #3336. I think the situation with riscv64 is quite similar to that case. The Go upstream also provides good support for riscv64.
Other Info
Co-authored by: nijincheng@iscas.ac.cn;