Skip to content

Revert "go_sdk: store SDK filenames and hashes in lockfile facts"#4432

Merged
fmeum merged 1 commit intomasterfrom
revert-4393-facts
Aug 25, 2025
Merged

Revert "go_sdk: store SDK filenames and hashes in lockfile facts"#4432
fmeum merged 1 commit intomasterfrom
revert-4393-facts

Conversation

@fmeum
Copy link
Copy Markdown
Member

@fmeum fmeum commented Aug 25, 2025

Reverts #4393

The facts feature didn't get merged in time for Bazel 8.4.0 and without it this PR caused an eager fetch of the version list for the default SDK.

@fmeum fmeum enabled auto-merge (squash) August 25, 2025 04:56
@fmeum fmeum requested review from jayconrod and linzhp August 25, 2025 04:56
@fmeum fmeum merged commit 6d90ede into master Aug 25, 2025
4 checks passed
@fmeum fmeum deleted the revert-4393-facts branch August 25, 2025 05:32
fmeum added a commit that referenced this pull request Oct 30, 2025
…4432)

This reverts commit 6d90ede.

Includes the following fixes:
* Adapted to the more limited facts API that actually got merged.
* Prefetching of SDK hashes is now performed on a best-effort basis so that otherwise airgapped builds that provide SDK hashes do not result in failures.
fmeum added a commit that referenced this pull request Oct 30, 2025
…4432)

This reverts commit 6d90ede.

Includes the following fixes:
* Adapted to the more limited facts API that actually got merged.
* Prefetching of SDK hashes is now performed on a best-effort basis so that otherwise airgapped builds that provide SDK hashes do not result in failures.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant