Gazelle: remove support for graphical multidiff#357
Merged
jayconrod merged 1 commit intobazel-contrib:masterfrom Apr 4, 2017
Merged
Gazelle: remove support for graphical multidiff#357jayconrod merged 1 commit intobazel-contrib:masterfrom
jayconrod merged 1 commit intobazel-contrib:masterfrom
Conversation
buildifier/differ supports both graphical and non-graphical diff. The graphical diff doesn't work though: it generates a command line for tkdiff, but tkdiff doesn't actually accept commands in that format. With this change, we just print diffs in the simple unified format by executing `diff -u`. Fixes bazel-contrib#342
Contributor
|
LGTM |
TvdW
pushed a commit
to TvdW/rules_go
that referenced
this pull request
Dec 23, 2025
…el-contrib#358) This PR adds support for built-in conversion functions, such as `string(x)`, used as index expr. Currently, without this support, NilAway reports a false positive for the example below. ``` func test(v uint8) { m := make(map[string]*int) if m[string(v)] != nil { _ = *m[string(v)] // false positive was reported here } } ``` Go compiler doesn't treat `string(x)` as a call to a built-in function named “string”, but instead it's considered to be a conversion using the predeclared type string. Therefore, our existing logic of `*types.BuiltIn` did not cover this case. We had to add special support for this case by checking for `pass.TypesInfo.ObjectOf(ident).Type().(*types.Basic)`. [Closes bazel-contrib#357 ]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildifier/differ supports both graphical and non-graphical
diff. The graphical diff doesn't work though: it generates a
command line for tkdiff, but tkdiff doesn't actually accept commands
in that format.
With this change, we just print diffs in the simple unified format by
executing
diff -u.Fixes #342