Skip to content

Implement “add” and “sub” functions for ARM-64 as well.#2830

Merged
jayconrod merged 1 commit intobazel-contrib:masterfrom
phst:arm64-addsub
Mar 8, 2021
Merged

Implement “add” and “sub” functions for ARM-64 as well.#2830
jayconrod merged 1 commit intobazel-contrib:masterfrom
phst:arm64-addsub

Conversation

@phst
Copy link
Copy Markdown
Contributor

@phst phst commented Feb 22, 2021

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

A bit of support for ARM-64.

Which issues(s) does this PR fix?

#2795 (not a complete fix, but a start)

@phst phst requested a review from jayconrod as a code owner February 22, 2021 22:37
@google-cla google-cla bot added the cla: yes label Feb 22, 2021
Copy link
Copy Markdown
Collaborator

@jayconrod jayconrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks, and sorry for the delay.

@jayconrod jayconrod merged commit caf08a7 into bazel-contrib:master Mar 8, 2021
@phst phst deleted the arm64-addsub branch March 8, 2021 17:24
yushan26 pushed a commit to yushan26/rules_go that referenced this pull request Jun 16, 2025
…#2831)

This just adds the code back at the original state before the following
PRs have been made to remove them: bazel-contrib#2629, bazel-contrib#2781. This has not been
hooked up yet in `evaluate_markers` and `whl_library` yet and I'll need
extra PRs to do that.

No CHANGELOG entries for now, will be done once the integration is back.

Work towards bazel-contrib#2830
yushan26 pushed a commit to yushan26/rules_go that referenced this pull request Jun 16, 2025
)

Handling of `python_full_version` correctly has been fixed in the
Starlark
implementation in bazel-contrib#2793 and in this PR I am backporting the changes to
handle
the full python version target platform strings so that we can have the
same
behaviour for now.

At the same time I have simplified and got rid of the specialization
handling
in the Python algorithm just like I did in the starlark, which
simplifies the
tests and makes the algorithm more correct.

Summary:
* Handle `cp3x.y_os_arch` strings in the `platform.py`
* Produce correct strings when the `micro_version` is unset. Note, that
we use version `0` in evaluating but we use the default version in the
config setting. This is to keep compatibility with the current behaviour
when the target platform is not fully specified (which would be the case
for WORKSPACE users).
* Adjust the tests and the code to be more similar to the starlark impl.

Work towards bazel-contrib#2830
yushan26 pushed a commit to yushan26/rules_go that referenced this pull request Jun 16, 2025
…contrib#2834)

Summary:
- Revert to using Python for marker evaluation during parsing of
  requirements (partial revert of bazel-contrib#2692).
- Use Python to parse whl METADATA.
- Bugfix the new simpler algorithm and add a new unit test.

Fixes bazel-contrib#2830
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants