Support Go 1.16#2821
Merged
jayconrod merged 2 commits intobazel-contrib:release-0.24from Feb 16, 2021
Merged
Conversation
The Go 1.16 linker appears stricter about fingerprinting. This test no longer works, but the behavior being tested was never supported. Sync with the test on master, which always expects an error.
achew22
approved these changes
Feb 16, 2021
| }) | ||
| } | ||
|
|
||
| func runTest(t *testing.T, expectError bool, extraArgs ...string) { |
Collaborator
Author
There was a problem hiding this comment.
It looks like the 1.16 linker is pickier about fingerprinting packages than 1.15. The test cases that worked before now fail.
I think it's best just to sync this test with master; we won't test with conflicts anymore since it's undefined behavior. If folks are relying on this, they'll need to stay below Go 1.16 or fix conflicts.
yushan26
pushed a commit
to yushan26/rules_go
that referenced
this pull request
Jun 16, 2025
…rib#2856) This reuses the previous work by @vonschultz who implemented a PEP440 version normalizer. We extend it and use it in the PEP508 marker evaluation. Summary: - Extend the normalization parser to output individual parts of the versions to the parsing context. - Re-implement all of the version comparison calls to use the parsed version. - Add extra validation for `.*` usage in the environment markers - Fallback to non-version matching in the environment markers if one of the sides is not a version. - Rename the original normalizer file to `version.bzl` because as far as Python is concerned this is the only version that there can be. We could in theory probably reuse this in other code where we are parsing the Python interpreter version many times, but this is left for the future. Fixes bazel-contrib#2826 Work towards bazel-contrib#2821 --------- Co-authored-by: Richard Levasseur <richardlev@gmail.com> Co-authored-by: Richard Levasseur <rlevasseur@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2820