builder: support appending to non-existant archive#2767
Merged
jayconrod merged 1 commit intobazel-contrib:masterfrom Dec 22, 2020
Merged
builder: support appending to non-existant archive#2767jayconrod merged 1 commit intobazel-contrib:masterfrom
jayconrod merged 1 commit intobazel-contrib:masterfrom
Conversation
In Go 1.16, 'go tool pack r' reports an error if the archive doesn't already exist (arguably a bug). The builder relied on this behavior (arguably also a bug). The builder will now create an empty archive before calling 'go tool pack r'. Note that 'go tool pack c' has some extra functionality (copying export data) beyond creating the archive, so we can't use that directly. Fixes bazel-contrib#2762
jayconrod
pushed a commit
that referenced
this pull request
Dec 23, 2020
In Go 1.16, 'go tool pack r' reports an error if the archive doesn't already exist (arguably a bug). The builder relied on this behavior (arguably also a bug). The builder will now create an empty archive before calling 'go tool pack r'. Note that 'go tool pack c' has some extra functionality (copying export data) beyond creating the archive, so we can't use that directly. Fixes #2762
jayconrod
pushed a commit
that referenced
this pull request
Dec 23, 2020
In Go 1.16, 'go tool pack r' reports an error if the archive doesn't already exist (arguably a bug). The builder relied on this behavior (arguably also a bug). The builder will now create an empty archive before calling 'go tool pack r'. Note that 'go tool pack c' has some extra functionality (copying export data) beyond creating the archive, so we can't use that directly. Fixes #2762
yushan26
pushed a commit
to yushan26/rules_go
that referenced
this pull request
Jun 16, 2025
These are just bugfixes to already merged code: * Fix nested bracket parsing in PEP508 marker parser. * Fix the sys_platform constants, which I noticed in bazel-contrib#2629 but they got also pointed out in bazel-contrib#2766. * Port some of python tests for requirement parsing and improve the implementation. Those tests will be removed in bazel-contrib#2629. * Move the platform related code to a separate file. * Rename `pep508_req.bzl` to `pep508_requirement.bzl` to follow the convention. All of the bug fixes have added tests. Work towards bazel-contrib#2423.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Go 1.16, 'go tool pack r' reports an error if the archive doesn't
already exist (arguably a bug). The builder relied on this behavior
(arguably also a bug).
The builder will now create an empty archive before calling
'go tool pack r'. Note that 'go tool pack c' has some extra
functionality (copying export data) beyond creating the archive, so we
can't use that directly.
Fixes #2762