proto: add protoc-gen-govalidators import#2532
Merged
jayconrod merged 1 commit intobazel-contrib:masterfrom Jun 5, 2020
Merged
proto: add protoc-gen-govalidators import#2532jayconrod merged 1 commit intobazel-contrib:masterfrom
jayconrod merged 1 commit intobazel-contrib:masterfrom
Conversation
This import is part of the generated files and was missing. Fixes bazel-contrib#2531
jayconrod
pushed a commit
that referenced
this pull request
Jul 8, 2020
This import is part of the generated files and was missing. Fixes #2531
yushan26
pushed a commit
to yushan26/rules_go
that referenced
this pull request
Jun 16, 2025
…-contrib#2532) The warning is somewhat non-actionable and the sources can be inspected via the MODULE.bazel.lock file if needed. This makes it easier to make this option a default at some point. At the same time cleanup the code since we are not using the `get_index_urls` to print the warning. Work towards bazel-contrib#260
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2531
See https://github.com/mwitkow/go-proto-validators/blob/master/examples/enum.validator.pb.go#L11 for an example of a generated file that imports this package. I'm using the
validators_golangsince that is the stack we're supporting with the existing plugin. See https://github.com/mwitkow/go-proto-validators/blob/master/BUILD.bazel#L83