Skip to content

Fix link error when go_binary is instrumented for coverage#2129

Merged
jayconrod merged 3 commits intobazel-contrib:masterfrom
jayconrod:go-binary-coverage
Jul 13, 2019
Merged

Fix link error when go_binary is instrumented for coverage#2129
jayconrod merged 3 commits intobazel-contrib:masterfrom
jayconrod:go-binary-coverage

Conversation

@jayconrod
Copy link
Copy Markdown
Collaborator

  • Include coverdata in arguments to link action
  • Add coverdata as an input

Fixes #2127

* Include coverdata in arguments to link action
* Add coverdata as an input

Fixes bazel-contrib#2127
Jay Conrod added 2 commits July 10, 2019 19:10
(coverage is not supported on windows, this just fixes something that
was obviously broken)
@jayconrod jayconrod merged commit d41409d into bazel-contrib:master Jul 13, 2019
@jayconrod jayconrod deleted the go-binary-coverage branch July 13, 2019 13:41
yushan26 pushed a commit to yushan26/rules_go that referenced this pull request Jun 16, 2025
Before this PR freethreaded toolchains were not possible to be used,
this adds the minimum plumbing to get the things working. Coverage
support is also added.

Whilst at it:
- Add plumbing to print checksums only for a particular python version.
- Bump the remaining toolchain versions that used to use the 20241008
release
- Pass around the loaded platform list so that we are only defining
toolchains for the platforms that we have loaded the hermetic toolchain
for.

Tested:
```
$ bazel run --//python/config_settings:python_version=3.13.0 --//python/config_settings:py_freethreaded="yes" //python/private:current_interpreter_executable
...
Python 3.13.0 experimental free-threading build (main, Oct 16 2024, 03:26:14) [Clang 18.1.8 ] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>>
```

Closes bazel-contrib#2129.
Work towards bazel-contrib#2386.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

go_binary does not build with bazel coverage

2 participants