Skip to content

Set RULES_GO_VERSION to 0.19.0#2069

Merged
jayconrod merged 1 commit intobazel-contrib:masterfrom
jayconrod:bump-version
May 19, 2019
Merged

Set RULES_GO_VERSION to 0.19.0#2069
jayconrod merged 1 commit intobazel-contrib:masterfrom
jayconrod:bump-version

Conversation

@jayconrod
Copy link
Copy Markdown
Collaborator

No description provided.

@jayconrod jayconrod requested a review from ianthehat as a code owner May 19, 2019 14:03
@jayconrod jayconrod merged commit dc13054 into bazel-contrib:master May 19, 2019
@jayconrod jayconrod deleted the bump-version branch May 19, 2019 15:50
yushan26 pushed a commit to yushan26/rules_go that referenced this pull request Jun 16, 2025
…around (bazel-contrib#2069)

This is extra preparation needed for bazel-contrib#2059.

Summary:
- Create `pypi_repo_utils` for more ergonomic handling of Python in repo
context.
- Split the resolution of requirements files to platforms into a
separate function
to make the testing easier. This also allows more validation that was
realized
  that there is a need for in the WIP feature PR.
- Make the code more robust about the assumption of the target platform
label.

Work towards bazel-contrib#260, bazel-contrib#1105, bazel-contrib#1868.
yushan26 pushed a commit to yushan26/rules_go that referenced this pull request Jun 16, 2025
…azel-contrib#2078)

It seems that a few things broke in recent commits:
- We are not using the `MODULE.bazel.lock` file and it seems that it is
easy to
  miss when the components in the PyPI extension stop integrating well
together. This happened during the switch to `{abi}_{os}_{plat}` target
  platform passing within the code.
- The logger code stopped working in the extension after the recent
additions
  to add the `rule_name`.
- `repo_utils.getenv` was always getting `PATH` env var on bazel `6.x`.

This PR fixes both cases and updates docs to serve as a better reminder.
By
fixing the `select_whls` code and we can just rely on target platform
triples
(ABI, OS, CPU). This gets one step closer to maybe supporting optional
`python_version` which would address bazel-contrib#1708. Whilst at it we are also
adding
different status messages for building the wheel from `sdist` vs just
extracting or downloading the wheel.

Tests:
- Added more unit tests and brought them in line with the rest of the
code.
- Checked manually for differences between the `MODULE.bazel.lock` files
in our
`rules_python` extension before bazel-contrib#2069 and after this PR and there are no
  differences except in the `experimental_target_platforms` attribute in
`whl_library`. Before this PR you would see that we do not select any
wheels
  for e.g. `MarkupSafe` and we are always building from `sdist`.

Work towards bazel-contrib#260.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants