go_binary: correctly apply x_defs to main package when linking#2001
Merged
jayconrod merged 1 commit intobazel-contrib:masterfrom Mar 20, 2019
Merged
go_binary: correctly apply x_defs to main package when linking#2001jayconrod merged 1 commit intobazel-contrib:masterfrom
jayconrod merged 1 commit intobazel-contrib:masterfrom
Conversation
Previously, if x_defs were specified for the main package, either implicitly (just a variable name) or explicitly (with the main package path), they were not applied by the linker. With this change, we replace -X pkg.key=value with -X main.key=value where pkg is the main package path. Fixes bazel-contrib#2000
jayconrod
added a commit
that referenced
this pull request
Apr 5, 2019
Previously, if x_defs were specified for the main package, either implicitly (just a variable name) or explicitly (with the main package path), they were not applied by the linker. With this change, we replace -X pkg.key=value with -X main.key=value where pkg is the main package path. Fixes #2000
jayconrod
added a commit
that referenced
this pull request
Apr 5, 2019
Previously, if x_defs were specified for the main package, either implicitly (just a variable name) or explicitly (with the main package path), they were not applied by the linker. With this change, we replace -X pkg.key=value with -X main.key=value where pkg is the main package path. Fixes #2000
jayconrod
added a commit
that referenced
this pull request
Apr 5, 2019
Previously, if x_defs were specified for the main package, either implicitly (just a variable name) or explicitly (with the main package path), they were not applied by the linker. With this change, we replace -X pkg.key=value with -X main.key=value where pkg is the main package path. Fixes #2000
blico
pushed a commit
to blico/rules_go
that referenced
this pull request
May 10, 2019
…-contrib#2001) Previously, if x_defs were specified for the main package, either implicitly (just a variable name) or explicitly (with the main package path), they were not applied by the linker. With this change, we replace -X pkg.key=value with -X main.key=value where pkg is the main package path. Fixes bazel-contrib#2000
yushan26
pushed a commit
to yushan26/rules_go
that referenced
this pull request
Jun 16, 2025
Remove dead code only used in tests. Work towards bazel-contrib#260
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if x_defs were specified for the main package, either
implicitly (just a variable name) or explicitly (with the main package
path), they were not applied by the linker.
With this change, we replace -X pkg.key=value with -X main.key=value
where pkg is the main package path.
Fixes #2000