Skip to content

Announce incompatible protobuf release [skip ci]#1968

Merged
jayconrod merged 1 commit intobazel-contrib:masterfrom
jayconrod:warn-protobuf
Feb 27, 2019
Merged

Announce incompatible protobuf release [skip ci]#1968
jayconrod merged 1 commit intobazel-contrib:masterfrom
jayconrod:warn-protobuf

Conversation

@jayconrod
Copy link
Copy Markdown
Collaborator

No description provided.

@jayconrod jayconrod requested a review from ianthehat as a code owner February 27, 2019 17:45
@jayconrod jayconrod merged commit 3fb00f6 into bazel-contrib:master Feb 27, 2019
@jayconrod jayconrod deleted the warn-protobuf branch February 27, 2019 17:46
yushan26 pushed a commit to yushan26/rules_go that referenced this pull request Jun 16, 2025
…el-contrib#1974)

Remove the `python_version` from `flag_values` and reduces the number of
targets we create by a lot because we no longer need to create all of
the micro
version combinations to also match when we want to match e.g. 3.10 on a
particular platform by using a trick I've learned in bazel-contrib#1968:
```starlark
select({
    "is_python_3.x": "my_config_setting"
    "//conditions:default": "is_python_3.x"
})
```

Then further optimization was done on how we create the aliases and
config
settings and optimizing the usage of `pip_whl` flag finally reduced the
internal number targets. The number config settings targets in
`//tests/private/pip_config_settings/...` where we have multiple python
versions has changed:

* `:is_*` - from **995** to **996** (the extra addition being
is_python_default).
* `:_.*is_*` - from **28272** to **2480** (just python version) and then
to **496** (final).

Work towards bazel-contrib#260
yushan26 pushed a commit to yushan26/rules_go that referenced this pull request Jun 16, 2025
This makes the exec tools toolchain disabled by default to prevent
toolchain resolution
from matching it and inadvertently pulling in a dependency on the
hermetic runtimes.
While the hermetic runtime wouldn't actually be used (precompiling is
disabled
by default), the dependency triggered downloading of the runtimes, which
breaks
environments which forbid remote downloads they haven't vetted (such a
case is
Bazel's own build process).

To fix this, a flag is added to control if the exec tools toolchain is
enabled or not.
When disabled (the default), the toolchain won't match, and the remote
dependency isn't
triggered.

Fixes bazel-contrib#1967.

---------

Co-authored-by: Richard Levasseur <rlevasseur@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants