Skip to content

Fix Windows & Darwin cross-compilation to Linux when using gRPC#1876

Merged
jayconrod merged 1 commit intobazel-contrib:masterfrom
ceason:fix-grpc-crosscompile
Jan 3, 2019
Merged

Fix Windows & Darwin cross-compilation to Linux when using gRPC#1876
jayconrod merged 1 commit intobazel-contrib:masterfrom
ceason:fix-grpc-crosscompile

Conversation

@ceason
Copy link
Copy Markdown
Contributor

@ceason ceason commented Dec 31, 2018

Fixes #1675

Copy link
Copy Markdown
Collaborator

@jayconrod jayconrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you squash org_golang_google_grpc-android.patch into this one? Seems like the same idea, so no need to maintain two separate patches.

@ceason ceason force-pushed the fix-grpc-crosscompile branch from 2f4e926 to 3bb9b06 Compare January 3, 2019 14:21
@ceason
Copy link
Copy Markdown
Contributor Author

ceason commented Jan 3, 2019

@jayconrod sure, patches are now combined

Copy link
Copy Markdown
Collaborator

@jayconrod jayconrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jayconrod jayconrod merged commit 4bc9ee1 into bazel-contrib:master Jan 3, 2019
yushan26 pushed a commit to yushan26/rules_go that referenced this pull request Jun 16, 2025
…epo (bazel-contrib#1837)

With this change we add support for platform-specific wheel registration
and
doing the selection of which wheel is used at build time.

This supports:
- Different package versions for different platforms.
- Use string_flags to configure what to fetch/select:
    - only whls, only sdist or auto mode.
    - libc version and `musl` vs `glibc` selection.
    - universal2 vs arch wheels for mac.
    - target osx version selection.

Summary of changes:
- The `uv pip install` would only warn the user of yanked packages but
  would not refuse to install them. Update our implementation to better
  match the same behaviour.
- A previous PR has added the support for passing it in the
`requirements_by_platform` and this just add the necessary code to make
  sure that we can also do the dependency management when parsing the
  `whl` `METADATA` files.
- Only configure `dev_pip` deps for `linux` and `osx` platforms to not
raise
  issues later.
- Add a function for generating a `whl_library` name from a `filename`.
- Add a macro for generating all config settings for a particular set of
parameters.
- Update `render_pkg_aliases` to also use those config settings.
- Update the toolchain selection `target_settings` to use the
`py_linux_libc`
config setting. With this the user can register a `musl` linux toolchain
if
  needed. We can also use similar `flag_values` to resolve bazel-contrib#1876.
- Integrate everything in the `pip` extension and setup cross-platform
  select statements.

Work towards bazel-contrib#1357, bazel-contrib#260

Stacked on bazel-contrib#1937
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants