Skip to content

fix: add sh_library loads for bazel 8.x support#414

Closed
aignas wants to merge 1 commit intobazel-contrib:mainfrom
aignas:fix/sh_library
Closed

fix: add sh_library loads for bazel 8.x support#414
aignas wants to merge 1 commit intobazel-contrib:mainfrom
aignas:fix/sh_library

Conversation

@aignas
Copy link
Copy Markdown

@aignas aignas commented Dec 11, 2024

rules_python depends on //tools:BUILD.bazel in the pre-commit hooks
and it seems that it is impossible to use bazel 8 yet.

@aignas
Copy link
Copy Markdown
Author

aignas commented Dec 11, 2024

It seems that the cgrindel/bazel-starlib is not using rules_shell, so
this is not sufficient.

github-merge-queue bot pushed a commit to bazel-contrib/rules_python that referenced this pull request Dec 11, 2024
Summary:
* Remove the old `7.x` config from all `.bazelrc`.
* Drop bazel 6 from example testing/support. The `.bazelrc`
  for enabling `WORKSPACE` cannot work across bazel 6,7,8.
* Add missing `BUILD.bazel` file for integration tests.
* Remove an integration test runner for `bazel 6.x`.
* RBE test for bazel 8 is still not working. 
* bump `rules_java` for internal WORKSPACE dependencies to
  a version that supports `8.x`.
* start running bazel-in-bazel integration tests using bazel `8.x`.
* until bazel-contrib/rules_bazel_integration_test#414 is merged,
  we need to use bazel 7 for the delete_packagese pre-commit hook,
  not sure about how to track this as the `cgrindel/bazel-lib` needs
  a new version.

Fixes #2378

---------

Co-authored-by: Richard Levasseur <richardlev@gmail.com>
@cgrindel
Copy link
Copy Markdown
Member

Thanks, @aignas. You are correct. I am working to support Bazel 8 in cgrindel/bazel-starlib. I hope to have something ready this weekend.

@katre katre closed this in #423 Jan 2, 2025
@katre katre closed this in 82b67d1 Jan 2, 2025
@aignas aignas deleted the fix/sh_library branch January 3, 2025 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants