Skip to content

Conversation

@robstewart57
Copy link

This relates to a reported issue with stack that uses this library:

commercialhaskell/stack#1017

And provides a preferred fix in place of a previous stack pull
request:

commercialhaskell/stack#1019

This relates to a reported issue with stack that uses this library:

commercialhaskell/stack#1017

And provides a preferred fix in place of a previous stack pull
request:

commercialhaskell/stack#1019
@UnkindPartition
Copy link

Hey Rob, why did you close this?

I haven't had a chance to look into the details yet. As I understand, this is needed to fix a bug in stack. Should the new function always be preferred to the old one in order to avoid the bug? Or are there partocilar conditions when one wants to use this? It would be nice if the docs provided a bit of guidance on that.

@UnkindPartition
Copy link

BTW, @Fuuzetsu, do we have a new repository for temporary (that we have control over)? The PR should probably go there.

@Fuuzetsu
Copy link

@feuerbach good point, we should create one. Do you want to do that?

@UnkindPartition
Copy link

Ok, done: https://github.com/feuerbach/temporary

@robstewart57
Copy link
Author

@Fuuzetsu @feuerbach Hi, and thanks for taking a look. I was about to tweak this stack PR for inclusion into stack: commercialhaskell/stack#1047 .

However, it would make more sense to have this PR be directed at the temporary library. One thing potentially holding that move back is whether @feuerbach has the hackage and stackage upload permissions (and perhaps the nod of approval from previous author at https://github.com/batterseapower/temporary ?). If you do have the upload rights for both, then I'll submit a PR in your direction, and then submit a PR to stack to use the canonicalised versions of withSystemTempDirectory and withTempDirectory from System.IO.Temp .

@UnkindPartition
Copy link

Yes, @Fuuzetsu and I are the new maintainers; we have hackage upload rights for temporary.

stackage doesn't need any special permissions; it uses hackage as the upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants