Conversation
…s to only do one setup + cleanup
Contributor
|
Looks great, two test runs passed 100% locally. Maybe update tools to master since I just merged basho/riak-client-tools#6 ? 👍 |
Contributor
Author
|
@lukebakken Ok, I'll do that and merge once buildbot gives me the green light. |
Contributor
|
Cool, I just made more merges to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes move the integration tests to use the bucket types and setup as specified in the riak-client-tools master branch.
This eliminates the need for a separate java-client branch of the tools.
Also did some refactoring to slow tests to provide a single shared setup/teardown for the classes instead of one for each individual test. This sped one 2i test up from 3s to 78ms.