Ready: Upgrade Testing Libs & fix non-deterministic test.#593
Ready: Upgrade Testing Libs & fix non-deterministic test.#593
Conversation
|
|
||
| @Test | ||
| public void testSystemDefaultCharsetIsReturnedIfNoPropertyIsDefined() | ||
| public void a_testSystemDefaultCharsetIsReturnedIfNoPropertyIsDefined() |
There was a problem hiding this comment.
They are, but I realized this smells more than I wanted. going to massage these tests a little more :/
|
Looks like we have some failing tests: |
|
How do you have your test-rig setup? Are we using the |
|
This is from the buildbot tests |
Gets around issue with using the default delete_mode in integration tests.
|
Attached is a zip from five test runs locally. Some were successful, some not. |
|
I wonder if oracle jdk would give different results. Thanks,
|
|
OK I'll give it a try. |
|
Unfortunately ... some of the same errors. I had to CTRL-C the last test, frozen on: |
…certs and usernames/passwords
Fix Security Tests
|
@javajolt @lukebakken Ok, this one should be ready now too. Fixes include all the security / buildbot fixes from PR #595. This should include everything that you've noted in this review so far. |
|
@alexmoore - is it worth making the changes to the tests at this point so the |
|
@lukebakken Now that we're using LevelDB as the default file system I think we can. I'd like to not stack anymore stuff into this cascade of PRs :/ I can start on that after we get these merged - I think I would need to change the bucket type names mostly, and then the other 80% unexpected work. |
|
Great! Please to be shipping 👍 |
Ready: Upgrade Testing Libs & fix non-deterministic test.
Upgrade Junit / Powermock / Mockito to latest versions, fix breaking changes.
Fix a non-deterministic test that @javajolt was seeing here: #582 (comment)