Skip to content

Ready: Upgrade Testing Libs & fix non-deterministic test.#593

Merged
alexmoore merged 37 commits intodevelopfrom
test-ordering
Mar 1, 2016
Merged

Ready: Upgrade Testing Libs & fix non-deterministic test.#593
alexmoore merged 37 commits intodevelopfrom
test-ordering

Conversation

@alexmoore
Copy link
Contributor

Upgrade Junit / Powermock / Mockito to latest versions, fix breaking changes.

Fix a non-deterministic test that @javajolt was seeing here: #582 (comment)

@alexmoore alexmoore changed the title Upgrade Testing Libs & fix non-deterministic test. Ready: Upgrade Testing Libs & fix non-deterministic test. Feb 9, 2016

@Test
public void testSystemDefaultCharsetIsReturnedIfNoPropertyIsDefined()
public void a_testSystemDefaultCharsetIsReturnedIfNoPropertyIsDefined()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these lettered to assure ordering?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are, but I realized this smells more than I wanted. going to massage these tests a little more :/

@hazen
Copy link

hazen commented Feb 12, 2016

Looks like we have some failing tests:

Failed tests:
  ITestRawIndexQuery.testBucketIndexHack:143 expected:<100> but was:<103>
  ITestSecondaryIndexQueryOp.testBucketIndexHack:540 null
  ITestDeleteOperation.testDeleteObjectTestType:46->testDeleteObject:73 expected:<{"value":"value"}> but was:<null>

@alexmoore
Copy link
Contributor Author

How do you have your test-rig setup? Are we using the java-client branch of riak-client-tools?

@hazen
Copy link

hazen commented Feb 12, 2016

This is from the buildbot tests

@lukebakken
Copy link
Contributor

Attached is a zip from five test runs locally. Some were successful, some not.

gh-593-test-runs.zip

@alexmoore
Copy link
Contributor Author

I wonder if oracle jdk would give different results.

Thanks,
Alex

On Feb 18, 2016, at 5:29 PM, Luke Bakken notifications@github.com wrote:

Attached is a zip from five test runs locally. Some were successful, some not.

gh-593-test-runs.zip


Reply to this email directly or view it on GitHub.

@lukebakken
Copy link
Contributor

OK I'll give it a try.

@lukebakken
Copy link
Contributor

Unfortunately ... some of the same errors. I had to CTRL-C the last test, frozen on:

Running com.basho.riak.client.core.operations.itest.ITestListKeysOperation

gh-593-oracle-test-runs.zip

@alexmoore
Copy link
Contributor Author

@javajolt @lukebakken Ok, this one should be ready now too. Fixes include all the security / buildbot fixes from PR #595. This should include everything that you've noted in this review so far.

@lukebakken
Copy link
Contributor

@alexmoore - is it worth making the changes to the tests at this point so the java-client branch in riak-client-tools can go away?

@alexmoore
Copy link
Contributor Author

@lukebakken Now that we're using LevelDB as the default file system I think we can. I'd like to not stack anymore stuff into this cascade of PRs :/ I can start on that after we get these merged - I think I would need to change the bucket type names mostly, and then the other 80% unexpected work.

@lukebakken
Copy link
Contributor

Great! Please to be shipping 👍

alexmoore added a commit that referenced this pull request Mar 1, 2016
Ready: Upgrade Testing Libs & fix non-deterministic test.
@alexmoore alexmoore merged commit 56a4be4 into develop Mar 1, 2016
@alexmoore alexmoore deleted the test-ordering branch March 1, 2016 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants