Fix RiakNode.Builder:setMaxConnections(0), clean up RiakNodeTest.java#582
Merged
Fix RiakNode.Builder:setMaxConnections(0), clean up RiakNodeTest.java#582
Conversation
|
I saw 1 test failure, but is probably unrelated: |
Contributor
Author
|
Yeah, that's completely unrelated. Need to figure out what went on with your test env, but that can wait until later. |
Contributor
Author
|
Ahh, your tests ran out of order. Not an issue with the code, will make the test cleanup better. |
|
👍 tests pass, code looks good. |
alexmoore
added a commit
that referenced
this pull request
Feb 2, 2016
Fix RiakNode.Builder:setMaxConnections(0), clean up RiakNodeTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses issue #580 (CLIENTS-685)
Add ability to set MaxConnections explicitly to 0 (unlimited), and cleanup the RiakNodeTest.java file a bit.
Add note about recommended minConnections. Wont' change the minConnections setting now, since it would break people's code that have maxConnections = 1 or 2.