Conversation
Contributor
There was a problem hiding this comment.
if (
This happens in several places.
Contributor
Author
There was a problem hiding this comment.
What happens several places? I only see one if :)
Contributor
There was a problem hiding this comment.
As we want to freeze the observable behavior, here is no needs to check internal state. better to verify as:
assertEquals(systemDefault.name(), DefaultCharset.get().name());
Contributor
Author
There was a problem hiding this comment.
But we're just testing/calling the initializer method b/c the charset for that class is static final, so we can't change it unless we restart the VM. Testing the initializer function should test everything except the actual assignment to the static final "singleton" variable.
alexmoore
added a commit
that referenced
this pull request
Sep 25, 2015
READY: Settable Default Charset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is from a customer request (JIRA CLIENTS-547), to have a settable default charset. Currently it's set to the JRE's default, which can change from machine to machine.
You can set it from the static
set()method on theDefaultCharsetclass, or from the command line by providing the charset name with the argcom.basho.riak.client.DefaultCharset. (e.g.java -Dcom.basho.riak.client.DefaultCharset="UTF-8" ...)Rendered Javadocs:
