CLIENTS-401 - Throw exception when resolving host is not possible#519
Merged
alexmoore merged 1 commit intobasho:developfrom Jul 22, 2015
calvernaz:develop
Merged
CLIENTS-401 - Throw exception when resolving host is not possible#519alexmoore merged 1 commit intobasho:developfrom calvernaz:develop
alexmoore merged 1 commit intobasho:developfrom
calvernaz:develop
Conversation
Contributor
|
Had to chew on this one but I think you've got it correct here. We should throw it on cluster.addNode() but not cluster.start(), with logging on the later. With RiakCluster, it should follow a "best-effort" path w.r.t. multiple nodes (healthcheck should mark misconfigured nodes as bad), so we should alert with the log and move along as much as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A possible fix for the issue #518