Conversation
4e03db0 to
e05cea9
Compare
Dotenv inline command substitutions incorrectly matches escaped
parentheses when parsing commands, so let's replace its regex with one
that doesn't.
This means that when you have a secrets file like:
```
SECRETS=$(kamal secrets fetch --adapter myadapter SECRET_WITH_PARENS)
SECRET_WITH_PARENS=$(kamal secrets extract SECRET_WITH_PARENS ${SECRETS})
```
Then we correctly add the secret even if it contains parentheses.
Currently if SECRET_WITH_PARENS=pass)word, then we get:
```
SECRET_WITH_PARENS=$(kamal secrets extract SECRET_WITH_PARENS pass\)word)
```
And dotenv's regex thinks the command is
`kamal secrets extract SECRET_WITH_PARENS pass\`.
e05cea9 to
a4e82fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dotenv inline command substitutions incorrectly matches escaped parentheses when parsing commands, so let's replace its regex with one that doesn't.
This means that when you have a secrets file like:
Then we correctly add the secret even if it contains parentheses.
Currently if SECRET_WITH_PARENS=pass)word, then we get:
And dotenv's regex thinks the command is
kamal secrets extract SECRET_WITH_PARENS pass\.Fixes: #1200