Handle parentheses in variables in commands#526
Closed
i7an wants to merge 3 commits intobkeepers:mainfrom
Closed
Conversation
|
Will this also fix #530 (improperly expanding double-quotes in command variables)? |
Contributor
Author
|
@mrj Unfortunately this PR does not fix the issue you reported. |
Owner
|
@i7an thanks for reporting this and coming up with a fix. I'm good with going forward with this, let me know when you're ready. Can you also add a test case that verifies that command => variable => command works? FOO=$(echo bar)
BAR-$(echo $FOO)Should equal FOO=bar
BAR=bar🐢 |
Contributor
Author
Contributor
Author
|
@bkeepers ping |
Contributor
Author
|
@bkeepers ping ping |
This was referenced Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Variables with parentheses are not handled correctly in commands:
Result:
The solution I suggest is to parse commands first and expand variables before executing commands.
Dependencies
This change will break
kamalwhich is included in Rails by default. This is how I want to handle it:dotenvpatch but not merge it.kamalHandle parentheses in variables in commands basecamp/kamal#1346kamalis released.