Skip to content

Adds the ability to download attachments that are in comments#55

Merged
robzolkos merged 1 commit into
basecamp:masterfrom
ardavis:master
Feb 10, 2026
Merged

Adds the ability to download attachments that are in comments#55
robzolkos merged 1 commit into
basecamp:masterfrom
ardavis:master

Conversation

@ardavis

@ardavis ardavis commented Feb 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Disclaimer: This was AI generated and could be sloppy.

I had issues downloading images when they were in comments instead of the card body. This PR seems to be working well for me and I'd like to share it.

$ fizzy card attachments download CARD_NUMBER [INDEX] [--include-comments] 
$ fizzy comment attachments show --card NUMBER                 
$ fizzy comment attachments download --card NUMBER [INDEX] 
  -o, --output FILENAME                                       # Exact name (single) or prefix (multiple: 'test' for test_1.png, test_2.png)

@ardavis ardavis marked this pull request as draft February 10, 2026 17:06
@ardavis ardavis marked this pull request as ready for review February 10, 2026 17:09
robzolkos
robzolkos approved these changes Feb 10, 2026
View reviewed changes

@robzolkos robzolkos left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice contribution! Tested this against a live board — comment attachments show/download and card attachments show/download --include-comments all work correctly.

Code is idiomatic Go and follows existing codebase patterns well. Unit tests are solid.

I've pushed e2e tests and README docs for the new commands to the comment-attachments-review branch (couldn't push directly to your fork).

Two minor notes for awareness (not blocking):

  • Errors from the comments API when using --include-comments are silently swallowed — users could get an empty result with no indication something went wrong.
  • The mention filtering in parseAttachments and the new -o prefix behavior for multi-file downloads are technically breaking changes for anyone scripting against attachment indices or the -o flag. We'll note these in the release.

@robzolkos robzolkos merged commit 80d361f into basecamp:master Feb 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robzolkos robzolkos robzolkos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ardavis @robzolkos