fix: remove intermediate .to_vec() in flashblock tx hash collection#749
Merged
fix: remove intermediate .to_vec() in flashblock tx hash collection#749
Conversation
Collaborator
✅ Heimdall Review Status
|
refcell
approved these changes
Feb 18, 2026
danyalprout
pushed a commit
that referenced
this pull request
Mar 5, 2026
* chore(cgt): remove current spec * feat(cgt): related specs Signed-off-by: Hex <165055168+hexshire@users.noreply.github.com> Co-authored-by: AgusDuha <81362284+agusduha@users.noreply.github.com> Co-authored-by: Joxes <91908708+Joxess@users.noreply.github.com> * fix: run linter * chore: add deauthorize function * chore: address review comments * chore: cgt review comments 2 Signed-off-by: Hex <165055168+hexshire@users.noreply.github.com> Co-authored-by: Joxes <91908708+Joxess@users.noreply.github.com> * chore(cgt): run checks and linters * chore: add deauthorize details * chore: add missing words * fix: update with the latest features * fix: comments * fix: comments * chore: run linters * fix: cgt flag (#74) * feat: remove fund func (#75) * feat: liquidity event (#76) * feat: remove fund func * fix: liquidity events * fix: donate eth (#73) * fix: donate eth * fix: comments * fix: donate eth * chore: run linter * chore: fix ci warning * chore: fix words file --------- Signed-off-by: Hex <165055168+hexshire@users.noreply.github.com> Signed-off-by: Ashitaka <96790496+ashitakah@users.noreply.github.com> Co-authored-by: AgusDuha <81362284+agusduha@users.noreply.github.com> Co-authored-by: Joxes <91908708+Joxess@users.noreply.github.com> Co-authored-by: Ashitaka <ashitaka@defi.sucks> Co-authored-by: Ashitaka <96790496+ashitakah@users.noreply.github.com>
haardikk21
pushed a commit
that referenced
this pull request
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotted a redundant .to_vec() while reading through build_next_flashblock — we slice into executed_transactions, clone everything into a new Vec, then immediately iterate to pull out tx hashes. Just using .iter() directly on the slice does the same thing without the extra allocation.