Skip to content

chore: remove tips-core crate#729

Merged
danyalprout merged 4 commits intomainfrom
danyal/remove-core-crate
Feb 14, 2026
Merged

chore: remove tips-core crate#729
danyalprout merged 4 commits intomainfrom
danyal/remove-core-crate

Conversation

@danyalprout
Copy link
Copy Markdown
Collaborator

@danyalprout danyalprout commented Feb 14, 2026

Description

Migrate tips-core logic into the existing crates. This does:

  • Bundle types → base-primitives
  • Kafka → tips-audit-lib (only used here)
  • Logging/metrics → use cli-utils

Misc:

  • Removed the FB's feature flag from base-primitives as it was always enabled.

@danyalprout
chore: remove tips-core crate
b11a3e4 
Distribute tips-core's code to proper homes and delete the crate:
- Bundle types (types.rs, test_utils.rs) → base-primitives
- Kafka config (kafka.rs) → tips-audit-lib
- Logging/metrics → replaced with cli-utils LogConfig/PrometheusServer
- Remove flashblocks feature flag from base-primitives (always enabled)
@danyalprout
chore: replace fully-qualified base_cli_utils types with imports
535929f
@cb-heimdall
Copy link
Copy Markdown
Collaborator

cb-heimdall commented Feb 14, 2026 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

github-actions[bot]
github-actions bot reviewed Feb 14, 2026
View reviewed changes
@danyalprout danyalprout marked this pull request as ready for review February 14, 2026 17:19
github-actions[bot]
github-actions bot reviewed Feb 14, 2026
View reviewed changes
github-actions[bot]
github-actions bot reviewed Feb 14, 2026
View reviewed changes
@danyalprout
chore: address PR review feedback
ead03ba 
- Make `bundles` module private with types re-exported from lib.rs
- Move bundle test helpers into `test_utils/` alongside existing test utilities
- Sort misc dependencies by line length (waterfall style)
- Simplify downstream imports to use `base_primitives::*` re-exports
- Remove stale flashblocks feature example from README
@danyalprout danyalprout force-pushed the danyal/remove-core-crate branch from bf1fdbe to ead03ba Compare February 14, 2026 18:59
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 14, 2026

Review Summary

Clean crate consolidation that removes tips-core by distributing its contents to appropriate homes:

  • Bundle types → base-primitives (correct: these are shared domain primitives)
  • Kafka config → tips-audit-lib (correct: only consumer)
  • Logging/metrics → replaced by base-cli-utils (correct: avoids duplication)

Observations

Dependency weight increase on base-primitives: The flashblocks feature gate was removed and its deps made unconditional. Additionally, the bundle types bring in op-alloy-consensus, op-alloy-flz, uuid, alloy-consensus, and alloy-eips as unconditional dependencies. Every consumer of base-primitives (even those only using the engine feature) now transitively pulls these in. This is a deliberate trade-off per the PR description ("Removed the FB's feature flag from base-primitives as it was always enabled") and seems reasonable given that all current consumers already had these deps or the flashblocks feature enabled.

#[cfg(all(test, feature = "test-utils"))] on bundle tests (line 370 of bundles/mod.rs): These tests will be silently skipped by cargo test -p base-primitives unless --features test-utils is passed. This is necessary because the tests import from crate::test_utils which is feature-gated. Just worth noting for CI configuration — ensure the test-utils feature is enabled when running the base-primitives test suite.

No correctness, safety, or concurrency issues found. The import migrations (alloy_provider::network::eip2718 → alloy_eips::eip2718, alloy_provider::network::TxSignerSync → op_alloy_network::TxSignerSync) are all correct.

@danyalprout danyalprout added this pull request to the merge queue Feb 14, 2026
Merged via the queue into main with commit f280c28 Feb 14, 2026
19 checks passed
@danyalprout danyalprout deleted the danyal/remove-core-crate branch February 14, 2026 20:27
danyalprout pushed a commit that referenced this pull request Mar 5, 2026
@JoshdfG
Include govenance token in predeploylist (#729)
031f360 
## Description

Include govenance token in predeploylist

## Metadata

Fixes #726
mw2000 pushed a commit that referenced this pull request Mar 7, 2026
@Farhad-Shabani
fix(validity): correct gap detection in agg proof validation (#729)
8c4e191 
* fix: reorder overlap/gap checks in agg validation

* chore: reorder validations in docstring

* fix: check < for gap
mw2000 pushed a commit that referenced this pull request Mar 9, 2026
@Farhad-Shabani @mw2000
fix(validity): correct gap detection in agg proof validation (#729)
58000bd 
* fix: reorder overlap/gap checks in agg validation

* chore: reorder validations in docstring

* fix: check < for gap
mw2000 pushed a commit that referenced this pull request Mar 16, 2026
@Farhad-Shabani @mw2000
fix(validity): correct gap detection in agg proof validation (#729)
c0fefed 
* fix: reorder overlap/gap checks in agg validation

* chore: reorder validations in docstring

* fix: check < for gap
haardikk21 pushed a commit that referenced this pull request Mar 17, 2026
@danyalprout
chore: remove tips-core crate (#729)
4735a86 
* chore: remove tips-core crate

Distribute tips-core's code to proper homes and delete the crate:
- Bundle types (types.rs, test_utils.rs) → base-primitives
- Kafka config (kafka.rs) → tips-audit-lib
- Logging/metrics → replaced with cli-utils LogConfig/PrometheusServer
- Remove flashblocks feature flag from base-primitives (always enabled)

* chore: replace fully-qualified base_cli_utils types with imports

* fix: enable test-utils feature for base-primitives in dev-dependencies

* chore: address PR review feedback

- Make `bundles` module private with types re-exported from lib.rs
- Move bundle test helpers into `test_utils/` alongside existing test utilities
- Sort misc dependencies by line length (waterfall style)
- Simplify downstream imports to use `base_primitives::*` re-exports
- Remove stale flashblocks feature example from README
haardikk21 pushed a commit that referenced this pull request Mar 17, 2026
@Farhad-Shabani @mw2000
fix(validity): correct gap detection in agg proof validation (#729)
11d3131 
* fix: reorder overlap/gap checks in agg validation

* chore: reorder validations in docstring

* fix: check < for gap
mw2000 pushed a commit that referenced this pull request Mar 19, 2026
@Farhad-Shabani @mw2000
fix(validity): correct gap detection in agg proof validation (#729)
d808312 
* fix: reorder overlap/gap checks in agg validation

* chore: reorder validations in docstring

* fix: check < for gap
mw2000 pushed a commit that referenced this pull request Mar 23, 2026
@Farhad-Shabani @mw2000
fix(validity): correct gap detection in agg proof validation (#729)
7df92d9 
* fix: reorder overlap/gap checks in agg validation

* chore: reorder validations in docstring

* fix: check < for gap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@refcell refcell refcell approved these changes

@haardikk21 haardikk21 Awaiting requested review from haardikk21

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@danyalprout @cb-heimdall @refcell