Clear pending Flashblocks on canonical catch-up and new metrics#65
Merged
danyalprout merged 1 commit intobase:mainfrom Aug 19, 2025
Merged
Clear pending Flashblocks on canonical catch-up and new metrics#65danyalprout merged 1 commit intobase:mainfrom
danyalprout merged 1 commit intobase:mainfrom
Conversation
danyalprout
requested changes
Aug 14, 2025
Collaborator
danyalprout
left a comment
There was a problem hiding this comment.
This looks great thanks, can we tweak the method name/signature. Regarding tests I wouldn't worry about it for now, we can handle that separately (I would like to make the state.rs stuff unit testable, but don't want to bloat this PR)
| } | ||
| } | ||
|
|
||
| pub fn clear_on_canonical_catchup(&self, canonical_number: u64) { |
Collaborator
There was a problem hiding this comment.
Can we call this on_canonical_block_received and update the params to take the full block, this:
- Is consistent with the Flashblocks method
- We're likely going to extend this method to do more than clear to fix Fix Flashblock state lookups for future blocks #59
| let flashblocks_enabled = flashblocks_rollup_args.flashblocks_enabled(); | ||
| let op_node = OpNode::new(flashblocks_rollup_args.rollup_args.clone()); | ||
|
|
||
| // Shared cell for a single FlashblocksState instance |
Collaborator
There was a problem hiding this comment.
nit: redundant comment
| .install_exex_if(flashblocks_enabled, "flashblocks-canon", { | ||
| let fb_cell = fb_cell.clone(); | ||
| move |mut ctx| async move { | ||
| // Initialize or reuse the shared state (created with ctx.provider()) |
Collaborator
There was a problem hiding this comment.
nit: redundant comment
Collaborator
|
I'm going to make these changes in a follow up PR |
0xsimulacra
pushed a commit
to 0xsimulacra/base-node-reth
that referenced
this pull request
Oct 1, 2025
Clear pending Flashblocks on canonical catch-up and new metrics
0xsimulacra
pushed a commit
to 0xsimulacra/base-node-reth
that referenced
this pull request
Oct 1, 2025
chore: follow ups for base#65
danyalprout
pushed a commit
that referenced
this pull request
Feb 12, 2026
* spike * move bundle logic inside * support both * better naming * default kafka
refcell
pushed a commit
that referenced
this pull request
Feb 18, 2026
refcell
pushed a commit
that referenced
this pull request
Feb 18, 2026
mw2000
pushed a commit
that referenced
this pull request
Mar 7, 2026
* zkl2oo contract cleanup * rm storage header
mw2000
pushed a commit
that referenced
this pull request
Mar 9, 2026
* zkl2oo contract cleanup * rm storage header
mw2000
pushed a commit
that referenced
this pull request
Mar 16, 2026
* zkl2oo contract cleanup * rm storage header
haardikk21
pushed a commit
that referenced
this pull request
Mar 17, 2026
* zkl2oo contract cleanup * rm storage header
mw2000
pushed a commit
that referenced
this pull request
Mar 19, 2026
* zkl2oo contract cleanup * rm storage header
mw2000
pushed a commit
that referenced
this pull request
Mar 23, 2026
* zkl2oo contract cleanup * rm storage header
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connects
FlashblocksStateto the canonical state stream so pending flashblocks are cleared when a canonical block with an equal or higher number is received. This uses a sharedArc<OnceCell<Arc<FlashblocksState>>>so both the ExEx listener and RPC module operate on the same state instance. Adds metrics to track pending snapshot height, flashblock index, and clear-on-catchup events.