fix(flashblocks): handle SystemTime edge case for clock adjustments#626
Merged
fix(flashblocks): handle SystemTime edge case for clock adjustments#626
Conversation
Collaborator
✅ Heimdall Review Status
|
Replace `.unwrap()` with fallback handling to prevent panics when system clock is adjusted backward (e.g., NTP correction, VM clock sync).
ce7d83b to
1f7ccb3
Compare
refcell
reviewed
Jan 30, 2026
refcell
reviewed
Jan 30, 2026
Contributor
|
Requesting @haardikk21 's review since he's more familiar with the builder code |
Test code and test_utils don't need fallback handling since they're outside the hot path. Keep logging only in production code.
Contributor
Author
|
Makes sense, reverted test code to use |
Collaborator
|
Is |
refcell
reviewed
Jan 30, 2026
refcell
reviewed
Jan 30, 2026
Per review feedback: instead of setting unix_now to zero (which would result in a very large deadline), return Duration::ZERO directly from the function. This way the effective deadline becomes 0.5s due to the extra time allotted by the caller.
Test utils code doesn't need clock error handling, keeping original.
Contributor
Author
|
@refcell Done |
Contributor
|
Can you resolve merge conflicts @Himess ? Thanks! |
Contributor
Author
|
@refcell Solved Thanks |
refcell
approved these changes
Feb 6, 2026
Contributor
refcell
left a comment
There was a problem hiding this comment.
This is good now, nice job
danyalprout
pushed a commit
that referenced
this pull request
Mar 5, 2026
mw2000
pushed a commit
that referenced
this pull request
Mar 7, 2026
* bump hokulea version and fix only ethda problem * name nit * rename eigenda_blob_provider to eigenda_preimage_provider * update elf * restore todo * chore: bump elf --------- Co-authored-by: BowenX <bxue@eigenlabs.org>
mw2000
pushed a commit
that referenced
this pull request
Mar 9, 2026
* bump hokulea version and fix only ethda problem * name nit * rename eigenda_blob_provider to eigenda_preimage_provider * update elf * restore todo * chore: bump elf --------- Co-authored-by: BowenX <bxue@eigenlabs.org>
mw2000
pushed a commit
that referenced
this pull request
Mar 16, 2026
* bump hokulea version and fix only ethda problem * name nit * rename eigenda_blob_provider to eigenda_preimage_provider * update elf * restore todo * chore: bump elf --------- Co-authored-by: BowenX <bxue@eigenlabs.org>
haardikk21
pushed a commit
that referenced
this pull request
Mar 17, 2026
…626) * fix(flashblocks): handle SystemTime edge case for clock adjustments Replace `.unwrap()` with fallback handling to prevent panics when system clock is adjusted backward (e.g., NTP correction, VM clock sync). * Revert test code to use unwrap() per review feedback Test code and test_utils don't need fallback handling since they're outside the hot path. Keep logging only in production code. * Return Duration::ZERO from job_deadline on clock error Per review feedback: instead of setting unix_now to zero (which would result in a very large deadline), return Duration::ZERO directly from the function. This way the effective deadline becomes 0.5s due to the extra time allotted by the caller. * Revert node.rs changes per review feedback Test utils code doesn't need clock error handling, keeping original.
haardikk21
pushed a commit
that referenced
this pull request
Mar 17, 2026
* bump hokulea version and fix only ethda problem * name nit * rename eigenda_blob_provider to eigenda_preimage_provider * update elf * restore todo * chore: bump elf --------- Co-authored-by: BowenX <bxue@eigenlabs.org>
mw2000
pushed a commit
that referenced
this pull request
Mar 19, 2026
* bump hokulea version and fix only ethda problem * name nit * rename eigenda_blob_provider to eigenda_preimage_provider * update elf * restore todo * chore: bump elf --------- Co-authored-by: BowenX <bxue@eigenlabs.org>
mw2000
pushed a commit
that referenced
this pull request
Mar 23, 2026
* bump hokulea version and fix only ethda problem * name nit * rename eigenda_blob_provider to eigenda_preimage_provider * update elf * restore todo * chore: bump elf --------- Co-authored-by: BowenX <bxue@eigenlabs.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #602