feat: add benchmark workflow for base-builder with base-reth-node validator#591
Merged
feat: add benchmark workflow for base-builder with base-reth-node validator#591
Conversation
Collaborator
✅ Heimdall Review Status
|
Contributor
Author
|
Next steps:
|
3 tasks
danyalprout
reviewed
Jan 28, 2026
danyalprout
reviewed
Jan 29, 2026
Collaborator
There was a problem hiding this comment.
@meyer9 this looks good to me, the benchmark job is failing to start reth (assuming this maybe due to the binary change or something), but should be good to go once fixed
dd1f34d to
aa83b64
Compare
Contributor
Author
|
dependent on base/benchmark#162 |
cdc5f98 to
05c292d
Compare
Adds a GitHub Actions workflow that benchmarks rbuilder as sequencer with base-reth-node (built from this repo) as the validator node. The workflow: - Builds base-reth-node with maxperf profile - Builds reth and rbuilder dependencies (with caching) - Runs transfer throughput benchmark (10 blocks, 1B gas limit) - Uploads benchmark output and HTML report as artifacts
- Build base-reth-node and rbuilder in a single job to share common crates - Remove reth build since it's not needed for this benchmark
Skip expensive builds when the same commit SHA and rbuilder version have already been built. All build steps are conditional on cache miss.
Use hash of Cargo.toml, Cargo.lock, crates/, and bin/ directories instead of commit SHA. This allows iterating on the benchmark workflow without triggering binary rebuilds.
05c292d to
2d23652
Compare
refcell
reviewed
Feb 4, 2026
refcell
reviewed
Feb 4, 2026
refcell
reviewed
Feb 4, 2026
| - name: Build base-builder | ||
| if: steps.cache-binaries.outputs.cache-hit != 'true' | ||
| run: | | ||
| cargo build --bin base-builder --profile maxperf |
Contributor
There was a problem hiding this comment.
My preference would be to have these as justfile targets so there's only one place where the production build target lives, but not a blocker.
Contributor
Author
There was a problem hiding this comment.
will address in next PR!
refcell
approved these changes
Feb 4, 2026
Contributor
refcell
left a comment
There was a problem hiding this comment.
gtg -- comments are non-blocking
refcell
pushed a commit
that referenced
this pull request
Feb 18, 2026
refcell
pushed a commit
that referenced
this pull request
Feb 18, 2026
haardikk21
pushed a commit
that referenced
this pull request
Mar 17, 2026
…idator (#591) * feat: add benchmark workflow for rbuilder with base-reth-node validator Adds a GitHub Actions workflow that benchmarks rbuilder as sequencer with base-reth-node (built from this repo) as the validator node. The workflow: - Builds base-reth-node with maxperf profile - Builds reth and rbuilder dependencies (with caching) - Runs transfer throughput benchmark (10 blocks, 1B gas limit) - Uploads benchmark output and HTML report as artifacts * refactor: combine binary builds to share compiled dependencies - Build base-reth-node and rbuilder in a single job to share common crates - Remove reth build since it's not needed for this benchmark * feat: cache binaries by commit SHA to avoid rebuilds Skip expensive builds when the same commit SHA and rbuilder version have already been built. All build steps are conditional on cache miss. * perf: cache binaries by source hash instead of commit SHA Use hash of Cargo.toml, Cargo.lock, crates/, and bin/ directories instead of commit SHA. This allows iterating on the benchmark workflow without triggering binary rebuilds. * Update to base-builder and remove checkout step * Debug log level * Use test branch * switch back * Use base-builder naming instead of rbuilder
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
.github/benchmark/rbuilder.yml- Benchmark configuration.github/workflows/benchmark.yml- GitHub Actions workflowThe workflow:
Test plan